Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds fleetauotscaler e2e test for Lists #3519

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Adds fleetauotscaler e2e test for Lists #3519

merged 1 commit into from
Nov 28, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Nov 21, 2023

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

@github-actions github-actions bot added the kind/feature New features for Agones label Nov 21, 2023
@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from 90be460 to 8ccc118 Compare November 21, 2023 21:45
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d09fac44-2066-48b2-940d-b45872fb42e2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from 82bc995 to e5c59cc Compare November 27, 2023 17:41
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 30a5f18c-82f2-4b15-8b6d-2380232c1312

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3519/head:pr_3519 && git checkout pr_3519
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-e5c59cc-amd64

@igooch igooch marked this pull request as ready for review November 27, 2023 19:46
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d8d35593-907a-4894-878e-ec5734a832a4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 49ba3122-a6dd-471e-85c6-5496357ba763

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3519/head:pr_3519 && git checkout pr_3519
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-be750b9-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 89adbfe6-5cc6-47b1-84dd-14888aa2292f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3519/head:pr_3519 && git checkout pr_3519
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-cb199e2-amd64

markmandel
markmandel approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@google-oss-prow google-oss-prow bot added the lgtm label Nov 28, 2023
@markmandel markmandel enabled auto-merge (squash) November 28, 2023 18:46
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 22ad971a-aceb-4ca2-ac18-fe4369ca3c89

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3519/head:pr_3519 && git checkout pr_3519
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-e677a38-amd64

@markmandel markmandel merged commit 89ed7f4 into googleforgames:main Nov 28, 2023
3 checks passed
@igooch igooch mentioned this pull request Jan 18, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@markmandel markmandel

Labels
approved kind/feature New features for Agones lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igooch @agones-bot @markmandel