-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CountsAndLists to Alpha #3527
Conversation
@@ -41,6 +41,7 @@ The current set of `alpha` and `beta` feature gates: | |||
|-----------------------------------------------------------------------------------------------------------------------|--------------------------------|----------|---------|--------| | |||
| [Allocated GameServers are notified on relevant Fleet Updates][fleet-updates] | `FleetAllocationOverflow` | Enabled | `Beta` | 1.37.0 | | |||
| [Split `agones-controller` ](https://github.com/googleforgames/agones/issues/2797) | `SplitControllerAndExtensions` | Enabled | `Beta` | 1.32.0 | | |||
| [CountsAndLists](https://github.com/googleforgames/agones/issues/2716) | `CountsAndLists` | Disabled | `Alpha` | 1.37.0 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change to formatting so that the columns are align with the rest of the feature stages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also remove pre-alpha in agones/install/helm/agones/defaultfeaturegates.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have aligned the format, removed pre-alpha in both the agones/install/helm/agones/defaultfeaturegates.yaml
and pkg/util/runtime/features.go
files
@@ -101,9 +101,7 @@ var ( | |||
FeaturePlayerAllocationFilter: false, | |||
FeaturePlayerTracking: false, | |||
FeatureDisableResyncOnSDKServer: false, | |||
|
|||
// Pre-Alpha features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also remove "Pre-alpha" on lines 51-52
Build Succeeded 👏 Build Id: 411b91ca-4f05-43ba-bd1c-18042812f061 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: igooch, Kalaiselvi84, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: 07ff5eb2-be5a-4008-9514-02d7974fcc9b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: