Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CountsAndLists to Alpha #3527

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@@ -41,6 +41,7 @@ The current set of `alpha` and `beta` feature gates:
|-----------------------------------------------------------------------------------------------------------------------|--------------------------------|----------|---------|--------|
| [Allocated GameServers are notified on relevant Fleet Updates][fleet-updates] | `FleetAllocationOverflow` | Enabled | `Beta` | 1.37.0 |
| [Split `agones-controller` ](https://github.com/googleforgames/agones/issues/2797) | `SplitControllerAndExtensions` | Enabled | `Beta` | 1.32.0 |
| [CountsAndLists](https://github.com/googleforgames/agones/issues/2716) | `CountsAndLists` | Disabled | `Alpha` | 1.37.0 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change to formatting so that the columns are align with the rest of the feature stages.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove pre-alpha in agones/install/helm/agones/defaultfeaturegates.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have aligned the format, removed pre-alpha in both the agones/install/helm/agones/defaultfeaturegates.yaml and pkg/util/runtime/features.go files

@@ -101,9 +101,7 @@ var (
FeaturePlayerAllocationFilter: false,
FeaturePlayerTracking: false,
FeatureDisableResyncOnSDKServer: false,

// Pre-Alpha features
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove "Pre-alpha" on lines 51-52

@google-oss-prow google-oss-prow bot added the lgtm label Dec 1, 2023
@google-oss-prow google-oss-prow bot removed the lgtm label Dec 1, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 411b91ca-4f05-43ba-bd1c-18042812f061

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3527/head:pr_3527 && git checkout pr_3527
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-3471e03-amd64

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igooch, Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel enabled auto-merge (squash) December 4, 2023 23:38
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 07ff5eb2-be5a-4008-9514-02d7974fcc9b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3527/head:pr_3527 && git checkout pr_3527
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-71bc4c9-amd64

@markmandel markmandel merged commit 330a548 into googleforgames:main Dec 5, 2023
3 checks passed
@Kalaiselvi84 Kalaiselvi84 added kind/feature New features for Agones and removed kind/other labels Dec 12, 2023
@Kalaiselvi84 Kalaiselvi84 deleted the CountsAndLists branch March 15, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants