Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix 404 on CI link testing #3542

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Not sure why, but youtube playlist links are 404ing.

I couldn't specify data-proofer-ignore since it's part of the Docsy layout, so I ignored it at the htmltest layer.

Did some minor cleanup while I was in there as well - updating some yaml formatting and updating the User-Agent as well.

Which issue(s) this PR fixes:

Unblocks CI

Special notes for your reviewer:

N/A

Not sure why, but youtube playlist links are 404ing.

I couldn't specify data-proofer-ignore since it's part of the Docsy
layout, so I ignored it at the htmltest layer.

Did some minor cleanup while I was in there as well - updating some yaml
formatting and updating the User-Agent as well.
@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/S labels Dec 14, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d98dab3c-8504-40d5-a40a-51cb9deb0f8a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3542/head:pr_3542 && git checkout pr_3542
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-9b2c1e5-amd64

@roberthbailey roberthbailey merged commit 9d5081e into googleforgames:main Dec 14, 2023
4 checks passed
@markmandel markmandel deleted the docs/404-yt branch December 14, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants