Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Counter and List Alpha.proto Methods #3544

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Dec 15, 2023

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:

While working on REST API conformance tests we discovered that the autogenerated swagger.json and REST API client did not generate working methods for GetCounter, UpdateList, etc. for Counters and Lists methods. This is due to the GetCounter, UpdateList, etc. methods using the https://google.aip.dev/231 suggested URI patterns like get: "/v1alpha1/{name=counters/*}". By updating to pattern get: "/v1alpha1/counters/{name}" we are able to generate working REST API code.

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/M labels Dec 15, 2023
@igooch igooch marked this pull request as ready for review December 15, 2023 04:02
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4d786ddf-6843-4461-bca5-42e070eb9983

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e6a4c801-3df0-4f7e-8e37-a3024edc8e17

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3544/head:pr_3544 && git checkout pr_3544
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-c4314bc-amd64

@zmerlynn zmerlynn enabled auto-merge (squash) December 15, 2023 17:15
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: eb5624b9-da71-4609-b798-80af47feb2dc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3544/head:pr_3544 && git checkout pr_3544
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-8854dc6-amd64

@zmerlynn zmerlynn merged commit 0f42cc1 into googleforgames:main Dec 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants