Updates to Counter and List Alpha.proto Methods #3544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind/cleanup
markmandel
reviewed
Dec 15, 2023
igooch
force-pushed
the
arbitrary-counts-lists-2716
branch
from
61e094e
to
c4314bc
Compare
|
Build Failed 😱 Build Id: 4d786ddf-6843-4461-bca5-42e070eb9983 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: e6a4c801-3df0-4f7e-8e37-a3024edc8e17 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
zmerlynn
approved these changes
Dec 15, 2023
|
Build Succeeded 👏 Build Id: eb5624b9-da71-4609-b798-80af47feb2dc The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
While working on REST API conformance tests we discovered that the autogenerated swagger.json and REST API client did not generate working methods for GetCounter, UpdateList, etc. for Counters and Lists methods. This is due to the GetCounter, UpdateList, etc. methods using the https://google.aip.dev/231 suggested URI patterns like
get: "/v1alpha1/{name=counters/*}". By updating to patternget: "/v1alpha1/counters/{name}"we are able to generate working REST API code.Which issue(s) this PR fixes:
Working on #2716
Special notes for your reviewer: