-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK Matrices for NodeJS, C#, CPP, REST #3548
Changes from 2 commits
0493526
e61e1a4
25008e3
5510b04
fea9e47
ef49bd1
292cf24
b003807
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -138,6 +138,41 @@ sdk->WatchGameServer([](const agones::dev::sdk::GameServer& gameserver){ | |
}); | ||
``` | ||
|
||
## SDK Functionality | ||
|
||
| Area | Action | Implemented | | ||
|-----------------|---------------------|-------------| | ||
| Lifecycle | Ready | ✔️ | | ||
| Lifecycle | Health | ✔️ | | ||
| Lifecycle | Reserve | ✔️ | | ||
| Lifecycle | Allocate | ✔️ | | ||
| Lifecycle | Shutdown | ✔️ | | ||
| Configuration | GameServer | ✔️ | | ||
| Configuration | Watch | ✔️ | | ||
| Metadata | SetAnnotation | ✔️ | | ||
| Metadata | SetLabel | ✔️ | | ||
| Counters | GetCounterCount | ❌ | | ||
| Counters | SetCounterCount | ❌ | | ||
| Counters | IncrementCounter | ❌ | | ||
| Counters | DecrementCounter | ❌ | | ||
| Counters | SetCounterCapacity | ❌ | | ||
| Counters | GetCounterCapacity | ❌ | | ||
| Lists | AppendListValue | ❌ | | ||
| Lists | DeleteListValue | ❌ | | ||
| Lists | SetListCapacity | ❌ | | ||
| Lists | GetListCapacity | ❌ | | ||
| Lists | ListContains | ❌ | | ||
| Lists | GetListLength | ❌ | | ||
| Lists | GetListValues | ❌ | | ||
| Player Tracking | GetConnectedPlayers | ✔️ | | ||
| Player Tracking | GetPlayerCapacity | ✔️ | | ||
| Player Tracking | GetPlayerCount | ✔️ | | ||
| Player Tracking | IsPlayerConnected | ✔️ | | ||
| Player Tracking | PlayerConnect | ✔️ | | ||
| Player Tracking | PlayerDisconnect | ✔️ | | ||
| Player Tracking | SetPlayerCapacity | ✔️ | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't see this implemented in agones/sdks/cpp/src/agones/sdk.cc |
||
|
||
|
||
For more information, you can also read the [SDK Overview]({{< relref "_index.md" >}}), check out | ||
{{< ghlink href="sdks/cpp/include/agones/sdk.h" >}}sdk.h{{< /ghlink >}} and also look at the | ||
{{< ghlink href="examples/cpp-simple" >}}C++ example{{< / >}}. | ||
|
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -166,6 +166,41 @@ var playerId = "player1"; | |||||||
bool isConnected = await agones.Alpha().IsPlayerConnectedAsync(playerId); | ||||||||
``` | ||||||||
|
||||||||
## SDK Functionality | ||||||||
|
||||||||
| Area | Action | Implemented | | ||||||||
|-----------------|---------------------|-------------| | ||||||||
| Lifecycle | Ready | ✔️ | | ||||||||
| Lifecycle | Health | ✔️ | | ||||||||
| Lifecycle | Reserve | ✔️ | | ||||||||
| Lifecycle | Allocate | ✔️ | | ||||||||
| Lifecycle | Shutdown | ✔️ | | ||||||||
| Configuration | GameServer | ✔️ | | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| Configuration | Watch | ✔️ | | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| Metadata | SetAnnotation | ✔️ | | ||||||||
| Metadata | SetLabel | ✔️ | | ||||||||
| Counters | GetCounterCount | ❌ | | ||||||||
| Counters | SetCounterCount | ❌ | | ||||||||
| Counters | IncrementCounter | ❌ | | ||||||||
| Counters | DecrementCounter | ❌ | | ||||||||
| Counters | SetCounterCapacity | ❌ | | ||||||||
| Counters | GetCounterCapacity | ❌ | | ||||||||
| Lists | AppendListValue | ❌ | | ||||||||
| Lists | DeleteListValue | ❌ | | ||||||||
| Lists | SetListCapacity | ❌ | | ||||||||
| Lists | GetListCapacity | ❌ | | ||||||||
| Lists | ListContains | ❌ | | ||||||||
| Lists | GetListLength | ❌ | | ||||||||
| Lists | GetListValues | ❌ | | ||||||||
| Player Tracking | GetConnectedPlayers | ✔️ | | ||||||||
| Player Tracking | GetPlayerCapacity | ✔️ | | ||||||||
| Player Tracking | GetPlayerCount | ✔️ | | ||||||||
| Player Tracking | IsPlayerConnected | ✔️ | | ||||||||
| Player Tracking | PlayerConnect | ✔️ | | ||||||||
| Player Tracking | PlayerDisconnect | ✔️ | | ||||||||
| Player Tracking | SetPlayerCapacity | ✔️ | | ||||||||
|
||||||||
|
||||||||
## Remarks | ||||||||
- All requests other than `ConnectAsync` will wait for up to 15 seconds before giving up, time to wait can also be set in the constructor. | ||||||||
- Default host & port are `localhost:9357` | ||||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -75,4 +75,39 @@ agonesSDK.watchGameServer((result) => { | |||||
|
||||||
To mark the game server as [reserved]({{< relref "_index.md#reserveseconds" >}}) for a period of time, call the async method `reserve(seconds)`. The result will be an empty object. | ||||||
|
||||||
## SDK Functionality | ||||||
|
||||||
| Area | Action | Implemented | | ||||||
|-----------------|---------------------|-------------| | ||||||
| Lifecycle | Ready | ✔️ | | ||||||
| Lifecycle | Health | ✔️ | | ||||||
| Lifecycle | Reserve | ✔️ | | ||||||
| Lifecycle | Allocate | ✔️ | | ||||||
| Lifecycle | Shutdown | ✔️ | | ||||||
| Configuration | GameServer | ✔️ | | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| Configuration | Watch | ✔️ | | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| Metadata | SetAnnotation | ✔️ | | ||||||
| Metadata | SetLabel | ✔️ | | ||||||
| Counters | GetCounterCount | ❌ | | ||||||
| Counters | SetCounterCount | ❌ | | ||||||
| Counters | IncrementCounter | ❌ | | ||||||
| Counters | DecrementCounter | ❌ | | ||||||
| Counters | SetCounterCapacity | ❌ | | ||||||
| Counters | GetCounterCapacity | ❌ | | ||||||
| Lists | AppendListValue | ❌ | | ||||||
| Lists | DeleteListValue | ❌ | | ||||||
| Lists | SetListCapacity | ❌ | | ||||||
| Lists | GetListCapacity | ❌ | | ||||||
| Lists | ListContains | ❌ | | ||||||
| Lists | GetListLength | ❌ | | ||||||
| Lists | GetListValues | ❌ | | ||||||
| Player Tracking | GetConnectedPlayers | ✔️ | | ||||||
| Player Tracking | GetPlayerCapacity | ✔️ | | ||||||
| Player Tracking | GetPlayerCount | ✔️ | | ||||||
| Player Tracking | IsPlayerConnected | ✔️ | | ||||||
| Player Tracking | PlayerConnect | ✔️ | | ||||||
| Player Tracking | PlayerDisconnect | ✔️ | | ||||||
| Player Tracking | SetPlayerCapacity | ✔️ | | ||||||
|
||||||
|
||||||
For more information, please read the [SDK Overview]({{< relref "_index.md" >}}), check out {{< ghlink href="sdks/nodejs/src/agonesSDK.js" >}}agonesSDK.js{{< /ghlink >}} and also look at the {{< ghlink href="examples/nodejs-simple" >}}Node.js example{{< / >}}. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,6 +36,18 @@ The same could be run for `alpha.swagger.json` and `beta.swagger.json` as requir | |
|
||
You can read more about OpenAPI/Swagger code generation in their [Command Line Tool Documentation](https://swagger.io/docs/open-source-tools/swagger-codegen/) | ||
|
||
## SDK Functionality | ||
|
||
| Area | Action | Implemented | | ||
|-----------|--------------------------------------------------------|-------------| | ||
| Counters | GET /v1alpha1/counters/{name} | ✔️ | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This part looks good to me. Do we want to add rows for other funcations like the other SDKs? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have the same question 🙋♀️ @igooch Looking forward to your inputs There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not entirely sure what Mark envisioned here, but I would start similarly to the "Action" column like we have in https://agones.dev/site/docs/guides/client-sdks/go/. Then below we can include the Path, Method, Body for each action. The actions for Counters are I would also include the existing actions "Ready", "Health" etc. that are named below in this doc. (The generated client API is at agones/test/sdk/restapi/swagger/api_sdk.go if you want to see the method names.) |
||
| Counters | PATCH /v1alpha1/counters/{counterUpdateRequest.name} | ✔️ | | ||
| Lists | PATCH /v1alpha1/lists/{list.name} | ✔️ | | ||
| Lists | GET /v1alpha1/lists/{name} | ✔️ | | ||
| Lists | POST /v1alpha1/lists/{name}:addValue | ✔️ | | ||
| Lists | POST /v1alpha1/lists/{name}:removeValue | ✔️ | | ||
|
||
Kalaiselvi84 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Reference | ||
|
||
### Lifecycle Management | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.