Increase performance test cluster size #3559
Conversation
github-actions
bot
added
kind/hotfix
|
Build Succeeded 👏 Build Id: 962b94f3-0457-4bdf-9c5b-2b4ccae902bc The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
| @@ -53,8 +53,8 @@ module "gke_standard_cluster" { | |||
| location = each.value[0] | |||
| overrideName = format("standard-performance-test-cluster-%s", replace(each.key, ".", "-")) | |||
| releaseChannel = each.value[1] | |||
| machineType = "n2-standard-2" | |||
| initialNodeCount = 300 | |||
| machineType = "e2-standard-4" | |||
There was a problem hiding this comment.
This is going to double the number of cores in the test cluster. Do you have autoscaling enabled to scale the number of nodes down when it isn't in use?
There was a problem hiding this comment.
Sorry I didn't make it quite clear in the PR description. The current test cluster is already using type "e2-standard-4" actually. The code here drifted from the fact by some mistake. So the only actual change in this PR is to increase the size to 310.
Good point to enable autoscaling. I will test and make a quick follow up PR for it.
| machineType = "n2-standard-2" | ||
| initialNodeCount = 300 | ||
| machineType = "e2-standard-4" | ||
| initialNodeCount = 310 |
There was a problem hiding this comment.
To piggyback on the above point, if we enable node autoscaling, then we should adjust the max number of allowed nodes as the initial node count wouldn't make any difference.
|
As a hotfix this seems reasonable, but I'd like to make sure we don't have a bunch of idle nodes sitting around when the tests aren't running. |
What type of PR is this?
/kind hotfix
What this PR does / Why we need it:
Performance test timed out because game servers cannot be created due to lack of CPU. Increasing the test cluster size to fix it.
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: