Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Docker to 24.0.6 #3567

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Conversation

Kalaiselvi84
Copy link
Contributor

@Kalaiselvi84 Kalaiselvi84 commented Jan 4, 2024

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Work on #3530

Special notes for your reviewer:

@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/XS labels Jan 4, 2024
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2c03840c-f90f-4edf-be16-7af5c56f7c30

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7002c93e-3c53-4b78-8808-95e6a608b623

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6e1441c1-ea60-433f-b9cc-212f546c21df

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3567/head:pr_3567 && git checkout pr_3567
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-670d647-amd64

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Lemme just take it for a spin on a machine that has Docker 24.x on it and make sure everything works

@markmandel
Copy link
Member

...and confirmed it works on Docker 24.x!

@Kalaiselvi84 Kalaiselvi84 marked this pull request as ready for review January 5, 2024 04:37
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's upgrade!

@markmandel markmandel enabled auto-merge (squash) January 8, 2024 01:02
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3c2e0b67-6767-4ae2-9ad2-db3f1beba8a1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3567/head:pr_3567 && git checkout pr_3567
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-2bbd360-amd64

@markmandel markmandel merged commit af75153 into googleforgames:main Jan 8, 2024
4 checks passed
@Kalaiselvi84 Kalaiselvi84 deleted the docker branch March 15, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/S size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants