Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Docker to 24.0.6 #3580

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Work on #3530

Special notes for your reviewer:

@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/XS labels Jan 9, 2024
@Kalaiselvi84
Copy link
Contributor Author

gcr.io/cloud-builders/docker is present in other files outside of the /example dir. Should we also update these files?

- name: gcr.io/cloud-builders/docker

- name: 'gcr.io/cloud-builders/docker'

- name: gcr.io/cloud-builders/docker

- "echo 'FROM gcr.io/cloud-builders/docker\nRUN apt-get install make\nENTRYPOINT\

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7e9c3abf-5ca1-4bd0-9691-7c4ae98eaa74

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3580/head:pr_3580 && git checkout pr_3580
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-18e2b93-amd64

@markmandel
Copy link
Member

That's a good question - yeah, let's be consistent across the board.

The only one I would exclude is [agones/build/build-image/cache/cloudbuild.yaml](https://github.com/googleforgames/agones/blob/a9348781de27f642cba28cbbf72903e44173900a/build/build-image/cache/cloudbuild.yaml#L30) just because we're essentially vendoring a third party cloud build script - so it's easier to keep it as close to the original as possible.

Did you want to make that change in this PR?

@Kalaiselvi84
Copy link
Contributor Author

I've updated the docker version outside of /examples and excluded the agones/build/build-image/cache/cloudbuild.yaml file

@Kalaiselvi84 Kalaiselvi84 changed the title Upgrade Docker in CI and Post-release Yaml Files Upgrade Docker 24.0.6 in /CI, /Build, and /Site Jan 10, 2024
@Kalaiselvi84 Kalaiselvi84 changed the title Upgrade Docker 24.0.6 in /CI, /Build, and /Site Upgrade Docker to 24.0.6 Jan 10, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1751cf34-3bc3-43cf-8205-f5a74cf1743e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3580/head:pr_3580 && git checkout pr_3580
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-3a590a0-amd64

@Kalaiselvi84
Copy link
Contributor Author

@gongmax We have updated all the necessary files with version 24.0.6 in this PR.

@Kalaiselvi84 Kalaiselvi84 marked this pull request as ready for review January 12, 2024 02:08
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7acf47ac-a408-4d89-8175-b2efb35f0c33

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3580/head:pr_3580 && git checkout pr_3580
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-d843d73-amd64

@gongmax gongmax merged commit 3243604 into googleforgames:main Jan 12, 2024
4 checks passed
@Kalaiselvi84 Kalaiselvi84 deleted the docker-ci-release branch March 15, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/S size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants