Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Example Images: Rust, Crd-client, NodeJS, Autoscaler-webhook #3587

Merged
merged 2 commits into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions examples/nodejs-simple/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ $ make run

The example can also be run via docker:
```
$ docker run --network=host us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.9
$ docker run --network=host us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.10
```
Or directly via npm:
```
Expand All @@ -51,7 +51,7 @@ $ npm start

You will see the output like the following:
```
docker run --network=host us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.9
docker run --network=host us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.10

> @ start /home/server/examples/nodejs-simple
> node src/index.js
Expand All @@ -63,22 +63,22 @@ Connecting to the SDK server...
To see help, pass `--help` as the argument (use the preferred command below, all are equivalent):
```
$ make args="--help" run
$ docker run --network=host us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.9 --help
$ docker run --network=host us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.10 --help
$ npm start -- --help
```

You can optionally specify how long the server will stay up once the basic tests are complete with the `--timeout` option.
To do this pass arguments through, e.g. to increase the shutdown duration to 120 seconds:
```
$ make args="--timeout=120" run
$ docker run --network=host us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.9 --timeout=120
$ docker run --network=host us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.10 --timeout=120
$ npm start -- --timeout=120
```

To make run indefinitely use the special timeout value of 0:
```
$ make args="--timeout=0" run
$ docker run --network=host us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.9 --timeout=0
$ docker run --network=host us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.10 --timeout=0
$ npm start -- --timeout=0
```

Expand All @@ -90,6 +90,6 @@ $ cd ../../build; make run-sdk-conformance-local TIMEOUT=120 FEATURE_GATES="Play
Then enable the alpha suite:
```
$ make args="--alpha" run
$ docker run --network=host us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.9 --alpha
$ docker run --network=host us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.10 --alpha
$ npm start -- --alpha
```
2 changes: 1 addition & 1 deletion examples/rust-simple/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ $ make run-image

You will see the following output:
```
docker run --network=host us-docker.pkg.dev/agones-images/examples/rust-simple-server:0.11
docker run --network=host us-docker.pkg.dev/agones-images/examples/rust-simple-server:0.13
Rust Game Server has started!
Creating SDK instance
Setting a label
Expand Down
2 changes: 1 addition & 1 deletion examples/rust-simple/gameserver.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ spec:
spec:
containers:
- name: rust-simple
image: us-docker.pkg.dev/agones-images/examples/rust-simple-server:0.11
image: us-docker.pkg.dev/agones-images/examples/rust-simple-server:0.13
imagePullPolicy: Always
2 changes: 1 addition & 1 deletion install/helm/agones/templates/tests/test-runner.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ spec:
serviceAccountName: agones-controller
containers:
- name: create-gameserver
image: us-docker.pkg.dev/agones-images/examples/crd-client:0.12
image: us-docker.pkg.dev/agones-images/examples/crd-client:0.13
imagePullPolicy: Always
env:
- name: GAMESERVER_IMAGE
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/examples_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func TestRustGameServerReady(t *testing.T) {
Containers: []corev1.Container{
{
Name: "rust-simple",
Image: "us-docker.pkg.dev/agones-images/examples/rust-simple-server:0.11",
Image: "us-docker.pkg.dev/agones-images/examples/rust-simple-server:0.13",
},
},
},
Expand Down Expand Up @@ -156,7 +156,7 @@ func TestNodeJSGameServerReady(t *testing.T) {
Containers: []corev1.Container{
{
Name: "nodejs-simple",
Image: "us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.9",
Image: "us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.10",
Resources: corev1.ResourceRequirements{
Requests: corev1.ResourceList{
corev1.ResourceMemory: resource.MustParse("100Mi"),
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/fleetautoscaler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ func defaultAutoscalerWebhook(namespace string) (*corev1.Pod, *corev1.Service) {
},
Spec: corev1.PodSpec{
Containers: []corev1.Container{{Name: "webhook",
Image: "us-docker.pkg.dev/agones-images/examples/autoscaler-webhook:0.9",
Image: "us-docker.pkg.dev/agones-images/examples/autoscaler-webhook:0.10",
ImagePullPolicy: corev1.PullAlways,
Ports: []corev1.ContainerPort{{
ContainerPort: 8000,
Expand Down