Support topologySpreadConstraints #3591

Kalaiselvi84 · 2024-01-11T21:56:48Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3533

Special notes for your reviewer:

agones-bot · 2024-01-11T22:53:05Z

Build Succeeded 👏

Build Id: f0474944-9fe5-4515-a30a-2459f6a00dbb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://c9c1682-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3591/head:pr_3591 && git checkout pr_3591
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-c9c1682-amd64

Kalaiselvi84 · 2024-01-12T22:18:41Z

I am getting YAML parse error on agones/templates/service/allocation.yaml: error converting YAML to JSON: yaml while testing and working on a solution.

agones-bot · 2024-01-12T22:30:45Z

Build Failed 😱

Build Id: 9479fb3c-2620-4e1c-bed4-be05ce01f107

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-01-16T21:59:11Z

Build Failed 😱

Build Id: c2ee307d-0d78-45fc-a5b1-368377544f99

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

install/helm/agones/templates/controller.yaml

agones-bot · 2024-01-24T19:29:38Z

Build Failed 😱

Build Id: 7b2298c1-c452-46c8-b614-2f1eb802d76e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-01-24T19:53:47Z

Build Failed 😱

Build Id: 61b8fd34-2aaa-4324-8889-158cc9d23644

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

gongmax · 2024-01-24T20:02:03Z

E2E test steps failed:

Already have image: e2e-runner
PlayerAllocationFilter=true&PlayerTracking=true&FleetAllocationOverflow=false&CountsAndLists=true&DisableResyncOnSDKServer=true&Example=true
Fetching cluster endpoint and auth data.
kubeconfig entry generated for standard-e2e-test-cluster-1-26.
/root/e2e.sh PlayerAllocationFilter=true&PlayerTracking=true&FleetAllocationOverflow=false&CountsAndLists=true&DisableResyncOnSDKServer=true&Example=true generic us-docker.pkg.dev/agones-images/ci
PlayerAllocationFilter=true&PlayerTracking=true&FleetAllocationOverflow=false&CountsAndLists=true&DisableResyncOnSDKServer=true&Example=true
us-docker.pkg.dev/agones-images/ci
installing current release
# if IMAGE_PULL_SECRET_FILE is specified, create the agones-system namespace and install the secret
bash -c '[[ $(helm status agones -n agones-system --output json | jq -r ".info.status") =~ (failed|pending-.*) ]] && helm uninstall agones --namespace=agones-system || true'
\
	helm upgrade --install --atomic --wait --timeout 10m --namespace=agones-system \
	--create-namespace \
	--set agones.image.tag=1.38.0-dev-b3017db,agones.image.registry="us-docker.pkg.dev/agones-images/ci" \
	--set agones.image.controller.pullPolicy="Always",agones.image.controller.pullSecret= \
	--set agones.image.extensions.pullPolicy="Always",agones.image.allocator.pullPolicy="Always" \
	--set agones.image.ping.pullPolicy="Always",agones.image.sdk.alwaysPull=true \
	--set agones.ping.http.serviceType="LoadBalancer",agones.ping.udp.serviceType="LoadBalancer" \
	--set agones.allocator.service.serviceType="LoadBalancer" \
	--set agones.controller.logLevel="debug" \
	--set agones.crds.cleanupOnDelete=true \
	--set agones.featureGates="PlayerAllocationFilter=true&PlayerTracking=true&FleetAllocationOverflow=false&CountsAndLists=true&DisableResyncOnSDKServer=true&Example=true" \
	--set agones.allocator.service.loadBalancerIP=104.155.231.222 \
	--set agones.metrics.serviceMonitor.enabled=false \
	 \
	agones /go/src/agones.dev/agones/install/helm/agones/
Error: UPGRADE FAILED: error validating "": error validating data: ValidationError(APIService.spec): unknown field "template" in io.k8s.kube-aggregator.pkg.apis.apiregistration.v1.APIServiceSpec
make: *** [Makefile:426: install] Error 1

install/helm/agones/templates/extensions.yaml

… pr-3533

agones-bot · 2024-01-24T22:23:27Z

Build Failed 😱

Build Id: 7f5a4617-f1d4-4e08-a5ea-8f3a02f32a2b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-01-24T23:13:31Z

Build Failed 😱

Build Id: 6e36e421-104b-4bc3-8363-e38f35d41df5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

install/helm/agones/templates/extensions.yaml

gongmax

You also need to add the config to ping, i.e. install/helm/agons/templates/ping.yaml

agones-bot · 2024-01-25T21:07:56Z

Build Failed 😱

Build Id: 44eea455-f6a8-47f9-9d33-1456ba013529

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-01-25T23:55:32Z

Build Succeeded 👏

Build Id: a9e98a4a-fc56-4e42-a49d-351338f73ace

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://c977279-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3591/head:pr_3591 && git checkout pr_3591
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-c977279-amd64

markmandel

Almost there - will also need updates to the docs in https://agones.dev/site/docs/installation/install-agones/helm/ with feature shortcodes please.

install/helm/agones/values.yaml

agones-bot · 2024-01-26T03:03:59Z

Build Succeeded 👏

Build Id: 1c9765e3-3256-4816-a3dc-91e08b42f60b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://60abae0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3591/head:pr_3591 && git checkout pr_3591
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-60abae0-amd64

agones-bot · 2024-01-26T04:06:27Z

Build Succeeded 👏

Build Id: 332bb8a4-ab7d-4cbe-aee0-21a8e8884ab3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://b11c190-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3591/head:pr_3591 && git checkout pr_3591
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-b11c190-amd64

agones-bot · 2024-01-26T18:52:46Z

Build Succeeded 👏

Build Id: 1a486597-5896-48a9-9bf2-bb2f985d6a89

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://ee88b8f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3591/head:pr_3591 && git checkout pr_3591
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-ee88b8f-amd64

agones-bot · 2024-01-26T21:57:04Z

Build Failed 😱

Build Id: ce816ed0-f88d-4c00-b400-97114e4e4eec

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

gongmax · 2024-01-26T23:55:48Z

install/helm/agones/templates/controller.yaml

@@ -60,6 +60,10 @@ spec:
        release: {{ .Release.Name }}
        heritage: {{ .Release.Service }}
    spec:
+      {{- if .Values.agones.controller.topologySpreadConstraints }}
+      topologySpreadConstraints:
+        {{- toYaml .Values.agones.controller.topologySpreadConstraints.constraints | nindent 8 }}


This can be simplified as {{- toYaml .Values.agones.controller.topologySpreadConstraints| nindent 8 }}, same for other components.

Included it to make the values as an array, otherwise CI will complain:

"e2e-feature-gates": Error: UPGRADE FAILED: error validating "": error validating data: ValidationError(Deployment.spec.template.spec.topologySpreadConstraints): invalid type for io.k8s.api.core.v1.PodSpec.topologySpreadConstraints: got "map", expected "array"

Disabling auto merge in case you want to discuss further @gongmax

markmandel · 2024-01-26T23:56:01Z

This flake again - generic-1.27:

time="2024-01-26 21:55:47.564" level=info msg="Finished Allocation."
    gameserverallocation_test.go:1417: 
        	Error Trace:	/go/src/agones.dev/agones/test/e2e/gameserverallocation_test.go:1417
        	Error:      	Not equal: 
        	            	expected: 100
        	            	actual  : 99
        	Test:       	TestGameServerAllocationDuringMultipleAllocationClients

Kalaiselvi84 · 2024-01-27T00:52:34Z

install.yaml file is missing 🤔
shall I submit another PR?

agones-bot · 2024-01-27T01:33:09Z

Build Succeeded 👏

Build Id: 843e0337-c5b0-4b1f-9cee-3684a8512b0c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://28cf37e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3591/head:pr_3591 && git checkout pr_3591
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-28cf37e-amd64

Kalaiselvi84 · 2024-01-27T01:34:14Z

I am silly; sorry for the confusion. There were no changes made to the install.yaml file with the final code update. I tested it with a new branch👍

agones-bot · 2024-01-27T05:57:10Z

Build Succeeded 👏

Build Id: c852707b-c335-4af5-a260-ace3b4273578

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://ce7c62d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3591/head:pr_3591 && git checkout pr_3591
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-ce7c62d-amd64

Kalaiselvi84 added 2 commits January 11, 2024 21:51

Support topologySpreadConstraints

025dae6

changes in allocator

c9c1682

Kalaiselvi84 requested review from markmandel and roberthbailey January 11, 2024 21:56

github-actions bot added kind/other size/S labels Jan 11, 2024

Kalaiselvi84 added 2 commits January 12, 2024 22:12

align indentation

4ce3ee3

Merge branch 'main' into pr-3533

f137a82

topologySpreadConstraints before affinity

560e7dd

markmandel reviewed Jan 23, 2024

View reviewed changes

install/helm/agones/templates/controller.yaml Show resolved Hide resolved

make gen-install

22d5acc

Kalaiselvi84 requested a review from gongmax January 24, 2024 18:30

Merge branch 'main' into pr-3533

b3017db

gongmax reviewed Jan 24, 2024

View reviewed changes

install/helm/agones/templates/extensions.yaml Outdated Show resolved Hide resolved

Kalaiselvi84 added 2 commits January 24, 2024 22:10

remove template/spec in extensions.yaml

8f12e4d

Merge branch 'pr-3533' of https://github.com/Kalaiselvi84/agones into…

f182847

… pr-3533

Kalaiselvi84 added 2 commits January 24, 2024 22:26

make gen-install

059e082

Merge branch 'main' into pr-3533

b65eeac

gongmax reviewed Jan 24, 2024

View reviewed changes

install/helm/agones/templates/extensions.yaml Outdated Show resolved Hide resolved

gongmax reviewed Jan 25, 2024

View reviewed changes

install/helm/agones/templates/extensions.yaml Outdated Show resolved Hide resolved

gongmax reviewed Jan 25, 2024

View reviewed changes

markmandel reviewed Jan 26, 2024

View reviewed changes

install/helm/agones/values.yaml Outdated Show resolved Hide resolved

Kalaiselvi84 added 2 commits January 26, 2024 01:25

no default values

5edffe7

Merge branch 'main' into pr-3533

60abae0

included new parameter to helm config tables

45f7923

github-actions bot added the size/M label Jan 26, 2024

Merge branch 'main' into pr-3533

b11c190

Merge branch 'main' into pr-3533

ee88b8f

Merge branch 'main' into pr-3533

33e8888

markmandel approved these changes Jan 26, 2024

View reviewed changes

gongmax reviewed Jan 26, 2024

View reviewed changes

markmandel enabled auto-merge (squash) January 26, 2024 23:56

markmandel disabled auto-merge January 27, 2024 00:11

Review changes

28cf37e

Merge branch 'main' into pr-3533

ce7c62d

gongmax approved these changes Jan 27, 2024

View reviewed changes

markmandel merged commit f445b49 into googleforgames:main Jan 27, 2024
4 checks passed

Kalaiselvi84 added kind/feature New features for Agones and removed kind/other labels Jan 29, 2024

Kalaiselvi84 deleted the pr-3533 branch March 15, 2024 01:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support topologySpreadConstraints #3591

Support topologySpreadConstraints #3591

Kalaiselvi84 commented Jan 11, 2024 •

edited

Loading

agones-bot commented Jan 11, 2024

Kalaiselvi84 commented Jan 12, 2024

agones-bot commented Jan 12, 2024

agones-bot commented Jan 16, 2024

agones-bot commented Jan 24, 2024

agones-bot commented Jan 24, 2024

gongmax commented Jan 24, 2024

agones-bot commented Jan 24, 2024

agones-bot commented Jan 24, 2024

gongmax left a comment

agones-bot commented Jan 25, 2024

agones-bot commented Jan 25, 2024

markmandel left a comment

agones-bot commented Jan 26, 2024

agones-bot commented Jan 26, 2024

agones-bot commented Jan 26, 2024

agones-bot commented Jan 26, 2024

gongmax Jan 26, 2024

Kalaiselvi84 Jan 27, 2024

markmandel Jan 27, 2024

markmandel commented Jan 26, 2024

Kalaiselvi84 commented Jan 27, 2024 •

edited

Loading

agones-bot commented Jan 27, 2024

Kalaiselvi84 commented Jan 27, 2024

agones-bot commented Jan 27, 2024

Support topologySpreadConstraints #3591

Support topologySpreadConstraints #3591

Conversation

Kalaiselvi84 commented Jan 11, 2024 • edited Loading

agones-bot commented Jan 11, 2024

Kalaiselvi84 commented Jan 12, 2024

agones-bot commented Jan 12, 2024

agones-bot commented Jan 16, 2024

agones-bot commented Jan 24, 2024

agones-bot commented Jan 24, 2024

gongmax commented Jan 24, 2024

agones-bot commented Jan 24, 2024

agones-bot commented Jan 24, 2024

gongmax left a comment

Choose a reason for hiding this comment

agones-bot commented Jan 25, 2024

agones-bot commented Jan 25, 2024

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Jan 26, 2024

agones-bot commented Jan 26, 2024

agones-bot commented Jan 26, 2024

agones-bot commented Jan 26, 2024

gongmax Jan 26, 2024

Choose a reason for hiding this comment

Kalaiselvi84 Jan 27, 2024

Choose a reason for hiding this comment

markmandel Jan 27, 2024

Choose a reason for hiding this comment

markmandel commented Jan 26, 2024

Kalaiselvi84 commented Jan 27, 2024 • edited Loading

agones-bot commented Jan 27, 2024

Kalaiselvi84 commented Jan 27, 2024

agones-bot commented Jan 27, 2024

Kalaiselvi84 commented Jan 11, 2024 •

edited

Loading

Kalaiselvi84 commented Jan 27, 2024 •

edited

Loading