Nodepool upgrades on GKE Terraform apply #3612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the docs: "...node pools defined inside a cluster can't be changed (or added/removed) after cluster creation without deleting and recreating the entire cluster." Which is not great - since you can end up with out-of-sync K8s versions between the control plane and nodes, an inability to change nodepool sizes and just a general lack of flexibility. Moving the node pool definitions out of the cluster definition solves this issue! Closes googleforgames#3339
|
Build Succeeded 👏 Build Id: d0f59444-e536-49fd-ac88-1762c6b2d450 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
I dropped a I don't expect it to be an issue since the older version wouldn't let you update nodes anyway, but better to be sure. |
gongmax
approved these changes
Jan 26, 2024
|
Build Failed 😱 Build Id: 00988c80-ec80-44d5-92d3-68ef938e7131 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: c7006833-e48f-4c0c-bb22-9707f114e436 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Per the docs:
"...node pools defined inside a cluster can't be changed (or added/removed) after cluster creation without deleting and recreating the entire cluster."
Which is not great - since you can end up with out-of-sync K8s versions between the control plane and nodes, an inability to change nodepool sizes and just a general lack of flexibility.
Moving the node pool definitions out of the cluster definition solves this issue!
Which issue(s) this PR fixes:
Closes #3339
Special notes for your reviewer:
This is the same terraform we use for our dev clusters on GKE.