Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to bump example images #3626

Merged
merged 7 commits into from
Feb 7, 2024

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@Kalaiselvi84 Kalaiselvi84 changed the title Bump example images Script to bump example images Feb 1, 2024
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 820fe236-187b-4248-b95d-bffb07f56e2e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 21571162-336a-429a-8e1d-23f6a000e590

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3626/head:pr_3626 && git checkout pr_3626
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-46c6a41-amd64

@Kalaiselvi84
Copy link
Contributor Author

I've tested this script with all the images and it is working fine. In this PR, I have updated a few images that hadn't been updated with the latest tag. Please share your feedback.👍🏻

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 20e5313b-e989-47e3-97fc-1d83fee882e5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3626/head:pr_3626 && git checkout pr_3626
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-0a248da-amd64


func init() {
flag.StringVar(&imageName, "imageName", "", "Image name to update")
flag.StringVar(&version, "version", "", "Version to update to")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understood correctly, the version here is the version we are going to update from, instead of update to, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This flag specifies the version that we want to update to the new tag. However, I am open to changing its description to either version to update from or simply version to update if that makes more sense.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1bc7c216-e262-4737-8a2c-ebb756141808

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3626/head:pr_3626 && git checkout pr_3626
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-45eb68b-amd64

Copy link
Collaborator

@gongmax gongmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel markmandel enabled auto-merge (squash) February 6, 2024 22:53
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 023052ac-e97d-42ff-9eaf-d4f83b9a307c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3626/head:pr_3626 && git checkout pr_3626
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-8b84784-amd64

@markmandel markmandel merged commit 903bf56 into googleforgames:main Feb 7, 2024
4 checks passed
@Kalaiselvi84 Kalaiselvi84 added kind/cleanup Refactoring code, fixing up documentation, etc and removed kind/other labels Mar 8, 2024
@Kalaiselvi84 Kalaiselvi84 deleted the bump-example-images branch March 15, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants