-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script to bump example images #3626
Script to bump example images #3626
Conversation
Build Failed 😱 Build Id: 820fe236-187b-4248-b95d-bffb07f56e2e To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 21571162-336a-429a-8e1d-23f6a000e590 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
I've tested this script with all the images and it is working fine. In this PR, I have updated a few images that hadn't been updated with the latest tag. Please share your feedback.👍🏻 |
Build Succeeded 👏 Build Id: 20e5313b-e989-47e3-97fc-1d83fee882e5 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
build/scripts/bump-image/main.go
Outdated
|
||
func init() { | ||
flag.StringVar(&imageName, "imageName", "", "Image name to update") | ||
flag.StringVar(&version, "version", "", "Version to update to") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understood correctly, the version
here is the version we are going to update from, instead of update to, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This flag specifies the version that we want to update to the new tag. However, I am open to changing its description to either version to update from
or simply version to update
if that makes more sense.
Build Succeeded 👏 Build Id: 1bc7c216-e262-4737-8a2c-ebb756141808 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build Succeeded 👏 Build Id: 023052ac-e97d-42ff-9eaf-d4f83b9a307c The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: