Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting: need git ... --add safe.directory #3638

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Ran into the ol' "error obtaining VCS status: exit status 128" issue, but this time with make lint.

Figured I'd move the command into a variable, so it can be reused across the Makefile.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Ran into the ol' "error obtaining VCS status: exit status 128" issue,
but this time with `make lint`.

Figured I'd move the command into a variable, so it can be reused across
the Makefile.
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Feb 9, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 20f0eea0-4f01-4866-8177-4752f262cb5d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3638/head:pr_3638 && git checkout pr_3638
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-d40ce54-amd64

@zmerlynn zmerlynn merged commit 5e964d4 into googleforgames:main Feb 9, 2024
4 checks passed
@markmandel markmandel deleted the cleanup/vcs-stamping branch February 12, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants