-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing values to Helm release of the Agones Terraform module #3665
Allow passing values to Helm release of the Agones Terraform module #3665
Conversation
Build Succeeded 👏 Build Id: 6732d936-3d4e-499e-b363-8679509fce15 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Thanks for sending this through! To compete this enhancement, can we also add documentation here for the new parameters please? You can see details on writing docs here: https://agones.dev/site/docs/contribute/ - the new parameters will need to go behind a |
…m/Pierca7/agones into 2729-terraform-module-helm-values
Build Succeeded 👏 Build Id: c4c02548-c22a-4888-ac33-778a7071216d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this!
Build Succeeded 👏 Build Id: e5a8a2ab-3afd-4dac-8828-f41e1250a682 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind feature
What this PR does / Why we need it:
As requested on allow passing Helm values directly to the Terraform module #2729, it allows to pass
set
,set_list
andset_sensitive
values to thehelm_release
resources of the Agones Terraform module.Which issue(s) this PR fixes:
Closes #2729