Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing values to Helm release of the Agones Terraform module #3665

Merged

Conversation

Pierca7
Copy link
Contributor

@Pierca7 Pierca7 commented Feb 20, 2024

What type of PR is this?
/kind feature

What this PR does / Why we need it:
As requested on allow passing Helm values directly to the Terraform module #2729, it allows to pass set, set_list and set_sensitive values to the helm_release resources of the Agones Terraform module.

Which issue(s) this PR fixes:
Closes #2729

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6732d936-3d4e-499e-b363-8679509fce15

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3665/head:pr_3665 && git checkout pr_3665
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-7bb0ae1-amd64

@markmandel
Copy link
Member

Thanks for sending this through!

To compete this enhancement, can we also add documentation here for the new parameters please?
https://agones.dev/site/docs/installation/terraform/gke/#installation

You can see details on writing docs here: https://agones.dev/site/docs/contribute/ - the new parameters will need to go behind a feature shortcode.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c4c02548-c22a-4888-ac33-778a7071216d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3665/head:pr_3665 && git checkout pr_3665
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-1c7f4b6-amd64

@Pierca7
Copy link
Contributor Author

Pierca7 commented Mar 10, 2024

Thanks for sending this through!

To compete this enhancement, can we also add documentation here for the new parameters please? https://agones.dev/site/docs/installation/terraform/gke/#installation

You can see details on writing docs here: https://agones.dev/site/docs/contribute/ - the new parameters will need to go behind a feature shortcode.

Done 👍

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this!

@markmandel markmandel enabled auto-merge (squash) March 11, 2024 05:16
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e5a8a2ab-3afd-4dac-8828-f41e1250a682

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3665/head:pr_3665 && git checkout pr_3665
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-1a0804d-amd64

@markmandel markmandel merged commit a9cd5b5 into googleforgames:main Mar 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow passing Helm values directly to the Terraform module
3 participants