Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info log level on Performance tests #3667

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

We don't need the full debug level on Agones for performance tests, especially since it brings us close to the quota limits on log writes.

Also updated the order of variables to make it a bit more readable.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:

I don't have a perf test cluster locally, but this should be fine -- but will keep an eye on the perf tests to make sure, and fix anything I break.

Also curious if this makes things go faster.

We don't need the full debug level on Agones for performance tests,
especially since it brings us close to the quota limits on log writes.

Also updated the order of variables to make it a bit more readable.
@markmandel markmandel added the area/performance Anything to do with Agones being slow, or making it go faster. label Feb 21, 2024
@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/XS labels Feb 21, 2024
@markmandel markmandel enabled auto-merge (squash) February 21, 2024 01:26
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9bd7d348-5e7f-42a3-b8a0-7e77002e29a0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3667/head:pr_3667 && git checkout pr_3667
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-de3d1e0-amd64

@markmandel markmandel merged commit 029700b into googleforgames:main Feb 21, 2024
4 checks passed
@markmandel markmandel deleted the perf/lower-log-level branch February 21, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Anything to do with Agones being slow, or making it go faster. kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants