Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify NewSDK(): Hardcode localhost #3676

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3634

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: eed8d681-970c-48dd-a8c0-ef643e575f6b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3676/head:pr_3676 && git checkout pr_3676
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-3ff5d01-amd64

@Kalaiselvi84
Copy link
Contributor Author

I tested it like this:

kalaiselvim@mkalai:~/Desktop/agones$ export AGONES_SDK_GRPC_HOST=localhost
kalaiselvim@mkalai:~/Desktop/agones$ export AGONES_SDK_GRPC_PORT=9357
================

test-newSDK/main.go:
--------------------
package main

import (
    "fmt"
    "log"
	sdk "agones.dev/agones/sdks/go"

)

func main() {
	log.Print("Creating SDK instance")
	sdk, err := sdk.NewSDK()
	if err != nil {
		log.Fatalf("Could not connect to sdk: %v", err)
	}
    fmt.Println("SDK successfully created:", sdk)
}
============================

kalaiselvim@mkalai:~/Desktop/agones/examples/test-newSDK$ go run main.go 
2024/02/29 01:40:03 Creating SDK instance
SDK successfully created: &{0xc000025720 {{}} 0xc000025790 0xc0000257b0}

please review the changes and share your feedback..

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 58f64498-0a86-4c17-b476-790decabe2a3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3676/head:pr_3676 && git checkout pr_3676
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-77c7a98-amd64

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Kalaiselvi84 Kalaiselvi84 marked this pull request as ready for review February 29, 2024 17:39
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 049fe7d5-9d38-4c05-aa57-74428facb8d6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3676/head:pr_3676 && git checkout pr_3676
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-8ed7477-amd64

@markmandel markmandel merged commit c5f85e5 into googleforgames:main Mar 4, 2024
4 checks passed
Ahmet-Kaplan added a commit to Zaim-Developers/agones that referenced this pull request Mar 4, 2024
@markmandel markmandel added the kind/feature New features for Agones label Mar 6, 2024
@Kalaiselvi84 Kalaiselvi84 deleted the localhost branch March 15, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewSDK configurable 'host'
3 participants