Adds Chat Message History and Connects to the NPC Chat API #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Succeeded 👏 Build Id: c349792d-03aa-423f-9020-4f57983d9f83 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
zmerlynn
requested changes
Mar 6, 2024
Separates out the NPC Request from the GenAIRequest. Updates the NPC Request to include the now required FromID and ToID fields.
|
Build Succeeded 👏 Build Id: 42a5224e-c7a7-4a1b-979a-ff3853382f25 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
zmerlynn
reviewed
Mar 8, 2024
zmerlynn
approved these changes
Mar 8, 2024
|
Build Failed 😱 Build Id: 46f40a08-5f1f-4757-93a7-00e899ebe545 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: 3889e6d1-4214-4267-a38d-ecee6a421460 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
Adds chat message history to the GenAI Request. This will make for better responses from VertexAI.
Adds the request type NPC which allows for making requests to the Google for Games GenAI NPC API.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
This works with Vertex, so in https://github.com/googleforgames/GenAI-quickstart/blob/205ba78aa65782f00a8654e31c88efdc4fdaded6/genai/api/npc_chat_api/config/config.toml#L20-L21 comment out "GKEGenAI", and uncomment "VertexAI".
You will need to first start up and run the GenAI Quickstart cluster, then start and run the NPC chat server.