-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Controller Example #3680
Conversation
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Build Failed 😱 Build Id: 17afffd0-ba12-4b89-a2e7-44c09ce17fd1 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Build Failed 😱 Build Id: 571db48f-e2ea-4643-af2a-3641e0d315c0 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
It seems that I need to perform more testing and make some changes in the main.go file. The logs are not appearing as expected. Here's what I have tried so far: https://gist.github.com/Kalaiselvi84/04a17eff8b74f3f1a07a75290fd68f2d
If we are planning to execute |
This is the RBAC service account we use for the SDK, you can likely copy a lot of it since the permissions shouldn't be that different. |
This helped fixing the problem. Here's the log for creating two gameservers - https://gist.github.com/Kalaiselvi84/76c46c443b3fb1254a7cf449effd8d96 I haven't yet reverted the go.mod and try it. Just double checking, is it necessary to revert the agones/go.mod file? |
Log for creating gameserver looks good, I guess? |
Looks pretty good! I am wondering why you are seeing "Entering into retry loop" -- also are the label updates happening? I'm also not seeing any RBAC changes in this PR, has that work been merged here? |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Build Failed 😱 Build Id: f72371b5-c90b-483e-bfa1-2eb0e5827777 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
I have merged the commit with the RBAC. I have seen error |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Build Failed 😱 Build Id: 1e23dc84-72af-4494-9282-ca4afd9074d4 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Build Failed 😱 Build Id: 7f72b811-beb9-401d-beba-06690cbdf851 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
I've included the log for the gameserver label. For deleting a gameserver, it always in the Here's the log- https://gist.github.com/Kalaiselvi84/56f0a74c3f27d8bb2c1dd0204f2418a8 Edit: |
Build Failed 😱 Build Id: 0608963b-d002-46ef-b6cc-9458f700090d To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Build Failed 😱 Build Id: 820cb31b-b4ad-4f00-891a-ec5e47ea1a26 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Build Failed 😱 Build Id: 21c89894-3333-427c-a19f-238662f6513e To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 33ebe87b-e6a3-43e2-abca-ab089e4f4a33 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Please review this testing log with the latest commit and share your feedback - https://gist.github.com/Kalaiselvi84/c5a576edebd1cc1c1ae5481c827fed17 Do we need to have 2 replicas? or 1 is enough? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of extra bits, but otherwise looks great.
name: custom-controller | ||
namespace: agones-system | ||
spec: | ||
replicas: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To you question in another box, this should be 1
replicas: 2 | |
replicas: 1 |
Good question - unless a controller has leader election you always want one of them, otherwise they can run into each other, trying to do the same things (this might be why you end up with so many conflicts?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding leader election to the example would be a good follow up task. It's worth filing a separate issue for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sound good. Filed this issue - #3694
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind taking a look at this log: https://gist.github.com/Kalaiselvi84/db200f984b4102ff2de7f7baf93b13a7? I'll proceed with pushing the image to production once you confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Build Failed 😱 Build Id: 22aace02-9841-4bd9-bcc8-d0bd36db6d5f To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Build Failed 😱 Build Id: 9986e39d-2aaa-4753-8803-6d3ecfbc7898 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Flake was installing agones into the cluster:
|
Build Succeeded 👏 Build Id: 555ae328-a6b5-4bf9-8250-4b444a05d750 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #3036
Special notes for your reviewer: