Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot load extensions image on minikube node #3682

Conversation

katsew
Copy link
Contributor

@katsew katsew commented Mar 6, 2024

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

When testing on minikube using locally built images, use minikube-push to load the built images on minikube.
At this time only the extensions image was not loaded.
This PR has been modified to load the extensions images that are not loaded.

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

NA

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ca871635-1f40-4423-be83-e85a89426c76

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3682/head:pr_3682 && git checkout pr_3682
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-a70e791-amd64

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice pickup - thanks! Been a while since I've used minikube for dev!

@markmandel markmandel enabled auto-merge (squash) March 7, 2024 03:33
@github-actions github-actions bot added the kind/bug These are bugs. label Mar 7, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 72cca2ce-0131-48cb-995e-786556b46308

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3682/head:pr_3682 && git checkout pr_3682
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-7b8f47e-amd64

@markmandel markmandel merged commit 1c536c0 into googleforgames:main Mar 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants