Counters & Lists: Consolidate priorities sorting
#3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing work on googleforgames#3649, realised the `priorities` sorting implementation between a `GameServerAllocation` and `Fleet/GameServerSet` was different. Once used available capacity, and the latter used current capacity. To make things simpler, both from an implementation point of view, and documentation and user understanding, this PR consolidates everything into using _available capacity_ across the board. This also includes: * Some refactoring to consolidate Counter and List priority sorting logic as much as possible. * Fixes a bug in `Packed` GameServerSet scale down logic. * Fixes for tests since logic changed. Additional context: googleforgames#3649 (comment)
markmandel
added
the
area/user-experience
|
Build Succeeded 👏 Build Id: 3c01d4e6-5186-4a90-87ff-b1e8aa6b031a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
roberthbailey
added
feature-freeze-do-not-merge
|
Build Succeeded 👏 Build Id: 8b10245e-f5d8-40a3-a6c6-229c276ff532 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
spiceratops
referenced
this pull request
in spiceratops/k8s-gitops
May 13, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [agones](https://agones.dev) ([source](https://github.com/googleforgames/agones)) | minor | `1.39.0` -> `1.40.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleforgames/agones (agones)</summary> ### [`v1.40.0`](https://github.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1400-2024-04-23) [Compare Source](https://github.com/googleforgames/agones/compare/v1.39.0...v1.40.0) [Full Changelog](https://github.com/googleforgames/agones/compare/v1.39.0...v1.40.0) **Breaking changes:** - Counters and Lists: Remove Bool Returns by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3738](https://github.com/googleforgames/agones/pull/3738) **Implemented enhancements:** - Leader Election in Custom Controller by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3696](https://github.com/googleforgames/agones/pull/3696) - Migrating from generate-groups.sh to kube_codegen.sh by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3722](https://github.com/googleforgames/agones/pull/3722) - Move GKEAutopilotExtendedDurationPods to Alpha in 1.28+ by [@​zmerlynn](https://github.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3729](https://github.com/googleforgames/agones/pull/3729) - Move DisableResyncOnSDKServer to Beta by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3732](https://github.com/googleforgames/agones/pull/3732) - Counters & Lists landing page and doc improvements by [@​markmandel](https://github.com/markmandel) in [https://github.com/googleforgames/agones/pull/3649](https://github.com/googleforgames/agones/pull/3649) - Graduate FleetAllocationOverflow to Stable by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3733](https://github.com/googleforgames/agones/pull/3733) - Adds Counters and Lists to CSharp SDK by [@​igooch](https://github.com/igooch) in [https://github.com/googleforgames/agones/pull/3581](https://github.com/googleforgames/agones/pull/3581) - Feat/counter and list defaulting order to ascending by [@​lacroixthomas](https://github.com/lacroixthomas) in [https://github.com/googleforgames/agones/pull/3734](https://github.com/googleforgames/agones/pull/3734) - Add handling for StatusAddresses in GameServerStatus for the Unity SDK by [@​charlesvien](https://github.com/charlesvien) in [https://github.com/googleforgames/agones/pull/3739](https://github.com/googleforgames/agones/pull/3739) - Feat(gameservers): Shared pod IPs with GameServer Addresses by [@​lacroixthomas](https://github.com/lacroixthomas) in [https://github.com/googleforgames/agones/pull/3764](https://github.com/googleforgames/agones/pull/3764) - Be prescriptive about rotating regions when updating Kubernetes versions by [@​zmerlynn](https://github.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3716](https://github.com/googleforgames/agones/pull/3716) - Fix ensure-e2e-infra-state-bucket by [@​zmerlynn](https://github.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3719](https://github.com/googleforgames/agones/pull/3719) - Create Performance Cluster 1.28 by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3720](https://github.com/googleforgames/agones/pull/3720) - Optimise GameServer Sub-Controller Queues by [@​markmandel](https://github.com/markmandel) in [https://github.com/googleforgames/agones/pull/3781](https://github.com/googleforgames/agones/pull/3781) **Fixed bugs:** - Counters & Lists: Consolidate `priorities` sorting by [@​markmandel](https://github.com/markmandel) in [https://github.com/googleforgames/agones/pull/3690](https://github.com/googleforgames/agones/pull/3690) - Fix(Counter & Lists): Add validation for `priorities` by [@​lacroixthomas](https://github.com/lacroixthomas) in [https://github.com/googleforgames/agones/pull/3714](https://github.com/googleforgames/agones/pull/3714) - fix: [#​3607](https://github.com/googleforgames/agones/issues/3607) Metrics data loss in K8S controller by [@​alvin-7](https://github.com/alvin-7) in [https://github.com/googleforgames/agones/pull/3692](https://github.com/googleforgames/agones/pull/3692) - Deflake GameServerAllocationDuringMultipleAllocationClients by allowing errors by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3750](https://github.com/googleforgames/agones/pull/3750) **Security fixes:** - Bump protobufjs from 7.2.4 to 7.2.6 in /sdks/nodejs by [@​dependabot](https://github.com/dependabot) in [https://github.com/googleforgames/agones/pull/3755](https://github.com/googleforgames/agones/pull/3755) - Bump golang.org/x/net from 0.19.0 to 0.23.0 by [@​zmerlynn](https://github.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3793](https://github.com/googleforgames/agones/pull/3793) **Other:** - Flaky: TestGameServerCreationAfterDeletingOneExtensionsPod by [@​markmandel](https://github.com/markmandel) in [https://github.com/googleforgames/agones/pull/3699](https://github.com/googleforgames/agones/pull/3699) - Prep for release v1.40.0 by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3700](https://github.com/googleforgames/agones/pull/3700) - Bumps cpp-simple Image and Refactoring Example Makefiles by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3695](https://github.com/googleforgames/agones/pull/3695) - Upgrade Protobuf to 1.33.0 by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3711](https://github.com/googleforgames/agones/pull/3711) - Modify Script for Makefile Version Updates in Examples Directory by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3712](https://github.com/googleforgames/agones/pull/3712) - Adds simple genai server example documentation to the Agones site by [@​igooch](https://github.com/igooch) in [https://github.com/googleforgames/agones/pull/3713](https://github.com/googleforgames/agones/pull/3713) - Update Supported Kubernetes to 1.27, 1.28, 1.29 by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3654](https://github.com/googleforgames/agones/pull/3654) - fix: typo in docs by [@​qhyun2](https://github.com/qhyun2) in [https://github.com/googleforgames/agones/pull/3723](https://github.com/googleforgames/agones/pull/3723) - Tweak: Setting up the Game Server by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3717](https://github.com/googleforgames/agones/pull/3717) - Docs: gke.md - spelling by [@​daniellee](https://github.com/daniellee) in [https://github.com/googleforgames/agones/pull/3740](https://github.com/googleforgames/agones/pull/3740) - Aesthetic rearrangement of cloudbuild.yaml by [@​zmerlynn](https://github.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3741](https://github.com/googleforgames/agones/pull/3741) - Docs: Make hitting <enter> on connection explicit by [@​markmandel](https://github.com/markmandel) in [https://github.com/googleforgames/agones/pull/3743](https://github.com/googleforgames/agones/pull/3743) - CI: Don't check Unreal Link by [@​markmandel](https://github.com/markmandel) in [https://github.com/googleforgames/agones/pull/3745](https://github.com/googleforgames/agones/pull/3745) - New recommendation for multi-cluster allocation by [@​markmandel](https://github.com/markmandel) in [https://github.com/googleforgames/agones/pull/3744](https://github.com/googleforgames/agones/pull/3744) - Custom Controller Example Page on Agones Website by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3725](https://github.com/googleforgames/agones/pull/3725) - Add Nitrado logo by [@​towolf](https://github.com/towolf) in [https://github.com/googleforgames/agones/pull/3753](https://github.com/googleforgames/agones/pull/3753) - Remove unnecessary args from e2e-test-cloudbuild by [@​zmerlynn](https://github.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3754](https://github.com/googleforgames/agones/pull/3754) - Update Allocation from Fleet Documentation by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3761](https://github.com/googleforgames/agones/pull/3761) - Transform Lint Warnings into Errors by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3756](https://github.com/googleforgames/agones/pull/3756) - Update Canary Testing Documentation by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3760](https://github.com/googleforgames/agones/pull/3760) - Supertuxkart Example on Agones Site by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3728](https://github.com/googleforgames/agones/pull/3728) - Xonotic Example on Agones Site by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3742](https://github.com/googleforgames/agones/pull/3742) - nit documentation fix in kind cluster section when building Agones by [@​vicentefb](https://github.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3770](https://github.com/googleforgames/agones/pull/3770) - Merged steps inside documentation about webhook certificate creation by [@​vicentefb](https://github.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3768](https://github.com/googleforgames/agones/pull/3768) - Example Images: Increment Tags by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3796](https://github.com/googleforgames/agones/pull/3796) - Update simple game server example documentation by [@​vicentefb](https://github.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3776](https://github.com/googleforgames/agones/pull/3776) **New Contributors:** - [@​lacroixthomas](https://github.com/lacroixthomas) made their first contribution in [https://github.com/googleforgames/agones/pull/3714](https://github.com/googleforgames/agones/pull/3714) - [@​daniellee](https://github.com/daniellee) made their first contribution in [https://github.com/googleforgames/agones/pull/3740](https://github.com/googleforgames/agones/pull/3740) - [@​charlesvien](https://github.com/charlesvien) made their first contribution in [https://github.com/googleforgames/agones/pull/3739](https://github.com/googleforgames/agones/pull/3739) - [@​vicentefb](https://github.com/vicentefb) made their first contribution in [https://github.com/googleforgames/agones/pull/3770](https://github.com/googleforgames/agones/pull/3770) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTYuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM1Ni4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Doing work on #3649, realised the
prioritiessorting implementation between aGameServerAllocationandFleet/GameServerSetwas different.Once used available capacity, and the latter used current capacity.
To make things simpler, both from an implementation point of view, and documentation and user understanding, this PR consolidates everything into using available capacity across the board.
Which issue(s) this PR fixes:
Additional context: #3649 (comment)
Special notes for your reviewer:
This also includes:
PackedGameServerSet scale down logic.