Fix(Counter & Lists): Add validation for priorities

[lacroixthomas]

What type of PR is this?

/kind bug

What this PR does / Why we need it:
Add validation of the priorities for the Counts and Lists feature.

Which issue(s) this PR fixes:

Closes #3684

Special notes for your reviewer:
This is my first contribution on this project, I'm open to any suggestions / changes, thanks !

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[agones-bot]

Build Succeeded 👏

Build Id: 7dfff481-df01-440e-8769-59acf2d488ec

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.40.0-dev-53ce695-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.40.0-dev-53ce695-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.40.0-dev-53ce695-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.40.0-dev-53ce695-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.40.0-dev-53ce695-amd64
• Linux C++ SDK (build): agonessdk-1.40.0-dev-53ce695-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.40.0-dev-53ce695-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://53ce695-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3714/head:pr_3714 && git checkout pr_3714
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-53ce695-amd64

[agones-bot]

Build Succeeded 👏

Build Id: 55d90737-94a3-4b7e-9452-b6a0b4a571f3

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.40.0-dev-a87d8ad-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.40.0-dev-a87d8ad-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.40.0-dev-a87d8ad-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.40.0-dev-a87d8ad-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.40.0-dev-a87d8ad-amd64
• Linux C++ SDK (build): agonessdk-1.40.0-dev-a87d8ad-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.40.0-dev-a87d8ad-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://a87d8ad-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3714/head:pr_3714 && git checkout pr_3714
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-a87d8ad-amd64

[markmandel]

Thanks for the submission! A lot of us are at GDC this week, so we might not get to review this until next week.

[igooch]

Thanks for the fix! One small comment, otherwise LGTM.

[igooch]

Suggested change

	allErrs = append(allErrs, field.Invalid(keyPath, priority.Order, "order must be \"Increment\" or \"Decrement\""))
	allErrs = append(allErrs, field.Invalid(keyPath, priority.Order, "order must be \"Ascending\" or \"Descending\""))

[lacroixthomas]

Youps missed that, just pushed the changes, Thanks !

[igooch]

LGTM

[agones-bot]

Build Failed 😱

Build Id: 19dbb758-dbd0-49dc-96f0-8a7e0279f244

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: 94a0d200-f6df-48a8-9661-d1821c59de7d

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.40.0-dev-b611aa8-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.40.0-dev-b611aa8-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.40.0-dev-b611aa8-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.40.0-dev-b611aa8-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.40.0-dev-b611aa8-amd64
• Linux C++ SDK (build): agonessdk-1.40.0-dev-b611aa8-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.40.0-dev-b611aa8-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://b611aa8-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3714/head:pr_3714 && git checkout pr_3714
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-b611aa8-amd64