Set Minimum Buffer Size to 1

pkg/fleetautoscalers/fleetautoscalers.go

@@ -28,16 +28,17 @@ import (
 	"strings"
 	"time"
 
+	"github.com/pkg/errors"
+	"k8s.io/apimachinery/pkg/util/intstr"
+	"k8s.io/apimachinery/pkg/util/uuid"
+
 	agonesv1 "agones.dev/agones/pkg/apis/agones/v1"
 	autoscalingv1 "agones.dev/agones/pkg/apis/autoscaling/v1"
 	listeragonesv1 "agones.dev/agones/pkg/client/listers/agones/v1"
 	"agones.dev/agones/pkg/fleets"
 	"agones.dev/agones/pkg/gameservers"
 	gssets "agones.dev/agones/pkg/gameserversets"
 	"agones.dev/agones/pkg/util/runtime"
-	"github.com/pkg/errors"
-	"k8s.io/apimachinery/pkg/util/intstr"
-	"k8s.io/apimachinery/pkg/util/uuid"
 )
 
 var tlsConfig = &tls.Config{}
@@ -323,6 +324,12 @@ func applyCounterOrListPolicy(c *autoscalingv1.CounterPolicy, l *autoscalingv1.L
 		desiredCapacity := int64(math.Ceil(float64(aggAllocatedCount*100) / float64(100-bufferPercent)))
 		// Convert into a desired AVAILABLE capacity aka the buffer
 		buffer = desiredCapacity - aggAllocatedCount
+
+		// Ensures buffer is at least 1
+		if buffer < 1 {
+			buffer = 1
+		}
+
 	}
 
 	// Current available capacity across the TOTAL fleet

pkg/fleetautoscalers/fleetautoscalers_test.go

@@ -24,17 +24,18 @@ import (
 	"net/http/httptest"
 	"testing"
 
-	agonesv1 "agones.dev/agones/pkg/apis/agones/v1"
-	autoscalingv1 "agones.dev/agones/pkg/apis/autoscaling/v1"
-	"agones.dev/agones/pkg/gameservers"
-	agtesting "agones.dev/agones/pkg/testing"
-	utilruntime "agones.dev/agones/pkg/util/runtime"
 	"github.com/stretchr/testify/assert"
 	admregv1 "k8s.io/api/admissionregistration/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/util/intstr"
 	k8stesting "k8s.io/client-go/testing"
+
+	agonesv1 "agones.dev/agones/pkg/apis/agones/v1"
+	autoscalingv1 "agones.dev/agones/pkg/apis/autoscaling/v1"
+	"agones.dev/agones/pkg/gameservers"
+	agtesting "agones.dev/agones/pkg/testing"
+	utilruntime "agones.dev/agones/pkg/util/runtime"
 )
 
 const (
@@ -1950,7 +1951,7 @@ func TestApplyListPolicy(t *testing.T) {
 							}}}},
 			},
 			want: expected{
-				replicas: 0,
+				replicas: 1,
 				limited:  false,
 				wantErr:  false,
 			},
@@ -2097,7 +2098,7 @@ func TestApplyListPolicy(t *testing.T) {
 			},
 			want: expected{
 				replicas: 1,
-				limited:  true,
+				limited:  false,
 				wantErr:  false,
 			},
 		},