-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update site documentation to reflect firewall prefix and default to Autopilot cluster creation for Agones #3769
Update site documentation to reflect firewall prefix and default to Autopilot cluster creation for Agones #3769
Conversation
…irewall prefix name and link
Build Succeeded 👏 Build Id: 6c8e50f4-0536-411c-b000-5abe6d5b9db1 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Failed 😱 Build Id: b31ceac1-3cb0-40b3-885b-e2a36123dbb3 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 870b3591-9600-4aef-bcf0-24451450933d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
@@ -2,7 +2,7 @@ | |||
{{- $test := eq (.Get "link_test") "true" | default true }} | |||
<p>The following prerequisites are required to create a GameServer:</p> | |||
<ol> | |||
<li>A Kubernetes cluster with the UDP port range 7000-8000 open on each node.</li> | |||
<li>A Kubernetes cluster with the UDP port range 7000-8000 open on each node. <a href="https://agones.dev/site/docs/installation/creating-cluster/gke/#creating-the-firewall">Creating the firewall</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should resolve to either the local or which snapshot version you are seeing - so it can't point at the domain directly.
You can use:
Line 15 in 772fffb
baseURL = "/site/" |
As the root of the link, via:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okok sg, i used /site/ now inside the href
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what @markmandel is saying is that even baseURL
could be variable, so you need to use a function here to grab the config.
@markmandel any reason we can't use https://gohugo.io/methods/site/baseurl/ here? I think this just becomes {{ .Site.BaseURL }}docs/installation/creating-cluster/gke/#creating-the-firewall
.
Build Succeeded 👏 Build Id: 1c3b19ba-ee02-490a-a72b-1a02028a98ed The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 602efab9-1dd1-41de-93c1-ccd557b362d3 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost!
@@ -2,7 +2,7 @@ | |||
{{- $test := eq (.Get "link_test") "true" | default true }} | |||
<p>The following prerequisites are required to create a GameServer:</p> | |||
<ol> | |||
<li>A Kubernetes cluster with the UDP port range 7000-8000 open on each node.</li> | |||
<li>A Kubernetes cluster with the UDP port range 7000-8000 open on each node. <a href="https://agones.dev/site/docs/installation/creating-cluster/gke/#creating-the-firewall">Creating the firewall</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what @markmandel is saying is that even baseURL
could be variable, so you need to use a function here to grab the config.
@markmandel any reason we can't use https://gohugo.io/methods/site/baseurl/ here? I think this just becomes {{ .Site.BaseURL }}docs/installation/creating-cluster/gke/#creating-the-firewall
.
Build Failed 😱 Build Id: 1bb3da91-09df-41e6-8569-77535b47d571 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 464b85ce-ccf9-4287-a091-97acf7c7983e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: a242b552-25da-4a4d-9294-df74a19697f7 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [agones](https://agones.dev) ([source](https://github.com/googleforgames/agones)) | minor | `1.40.0` -> `1.41.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleforgames/agones (agones)</summary> ### [`v1.41.0`](https://github.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1410-2024-06-04) [Compare Source](https://github.com/googleforgames/agones/compare/v1.40.0...v1.41.0) [Full Changelog](https://github.com/googleforgames/agones/compare/v1.40.0...v1.41.0) **Implemented enhancements:** - Configure Allocator Status Code by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3782](https://github.com/googleforgames/agones/pull/3782) - Graduate Counters and Lists to Beta by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3801](https://github.com/googleforgames/agones/pull/3801) - Passthrough autopilot - Adds an AutopilotPassthroughPort Feature Gate and new pod label by [@​vicentefb](https://github.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3809](https://github.com/googleforgames/agones/pull/3809) - CountsAndLists: Move to Beta Protobuf by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3806](https://github.com/googleforgames/agones/pull/3806) - feat: support multiple port ranges by [@​nrwiersma](https://github.com/nrwiersma) in [https://github.com/googleforgames/agones/pull/3747](https://github.com/googleforgames/agones/pull/3747) - Changes `sdk-server` to Patch instead of Update by [@​igooch](https://github.com/igooch) in [https://github.com/googleforgames/agones/pull/3803](https://github.com/googleforgames/agones/pull/3803) - Generate grpc for nodejs from alpha to beta by [@​lacroixthomas](https://github.com/lacroixthomas) in [https://github.com/googleforgames/agones/pull/3825](https://github.com/googleforgames/agones/pull/3825) - Update CountsAndLists from Alpha to Beta by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3824](https://github.com/googleforgames/agones/pull/3824) - feat(gameserver): New DirectToGameServer PortPolicy allows direct traffic to a GameServer by [@​daniellee](https://github.com/daniellee) in [https://github.com/googleforgames/agones/pull/3807](https://github.com/googleforgames/agones/pull/3807) - Passthrough autopilot - Adds mutating webhook by [@​vicentefb](https://github.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3833](https://github.com/googleforgames/agones/pull/3833) - Passthrough autopilot - added ports array case and updated unit tests by [@​vicentefb](https://github.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3842](https://github.com/googleforgames/agones/pull/3842) - Nodejs counters and lists by [@​steven-supersolid](https://github.com/steven-supersolid) in [https://github.com/googleforgames/agones/pull/3726](https://github.com/googleforgames/agones/pull/3726) - Promote AutopilotPassthroughPort feature gate to Alpha by [@​vicentefb](https://github.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3849](https://github.com/googleforgames/agones/pull/3849) **Fixed bugs:** - Helm Param Update: Default to agones.controller if agones.extensions is Missing by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3773](https://github.com/googleforgames/agones/pull/3773) - fix: rollout strategy issues by [@​nrwiersma](https://github.com/nrwiersma) in [https://github.com/googleforgames/agones/pull/3762](https://github.com/googleforgames/agones/pull/3762) - Set Minimum Buffer Size to 1 by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3749](https://github.com/googleforgames/agones/pull/3749) - Pin ltsc2019 to older SHA by [@​zmerlynn](https://github.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3829](https://github.com/googleforgames/agones/pull/3829) - TestGameServerAllocationDuringMultipleAllocationClients: Readdress flake by [@​zmerlynn](https://github.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3831](https://github.com/googleforgames/agones/pull/3831) - Refactor finalizer name to include valid domain name and path by [@​indexjoseph](https://github.com/indexjoseph) in [https://github.com/googleforgames/agones/pull/3840](https://github.com/googleforgames/agones/pull/3840) - agones-{extensions,allocator}: Be more defensive about draining by [@​zmerlynn](https://github.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3839](https://github.com/googleforgames/agones/pull/3839) - agones-{extensions,allocator}: Pause after cancelling context by [@​zmerlynn](https://github.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3843](https://github.com/googleforgames/agones/pull/3843) - Change the line to modify in Quickstart: Edit a Game Server by [@​peterzhongyi](https://github.com/peterzhongyi) in [https://github.com/googleforgames/agones/pull/3844](https://github.com/googleforgames/agones/pull/3844) **Other:** - Prep for Release v1.41.0 by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3800](https://github.com/googleforgames/agones/pull/3800) - Update site documentation to reflect firewall prefix and default to Autopilot cluster creation for Agones by [@​vicentefb](https://github.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3769](https://github.com/googleforgames/agones/pull/3769) - Add a System Diagram and overview page by [@​zmerlynn](https://github.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3792](https://github.com/googleforgames/agones/pull/3792) - Update Side Menu: Preserve and Restore Scroll Position by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3805](https://github.com/googleforgames/agones/pull/3805) - fix: typo by [@​skmpf](https://github.com/skmpf) in [https://github.com/googleforgames/agones/pull/3808](https://github.com/googleforgames/agones/pull/3808) - Helm Config: Add httpUnallocatedStatusCode in Allocator Service by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3802](https://github.com/googleforgames/agones/pull/3802) - Update Docs: CountersAndLists to Beta by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3810](https://github.com/googleforgames/agones/pull/3810) - Disable Dev feature FeatureAutopilotPassthroughPort by [@​vicentefb](https://github.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3815](https://github.com/googleforgames/agones/pull/3815) - Disable FeatureAutopilotPassthroughPort in features.go by [@​vicentefb](https://github.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3816](https://github.com/googleforgames/agones/pull/3816) - SDK proto compatibility guarantees and deprecation policies documentation by [@​igooch](https://github.com/igooch) in [https://github.com/googleforgames/agones/pull/3774](https://github.com/googleforgames/agones/pull/3774) - Fix dangling "as of" by [@​zmerlynn](https://github.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3827](https://github.com/googleforgames/agones/pull/3827) - Steps to Promote SDK Features from Alpha to Beta by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3814](https://github.com/googleforgames/agones/pull/3814) - Adds comment for help troubleshooting issues with terraform tfstate by [@​igooch](https://github.com/igooch) in [https://github.com/googleforgames/agones/pull/3822](https://github.com/googleforgames/agones/pull/3822) - docs: improve counter and list example comments by [@​yonbh](https://github.com/yonbh) in [https://github.com/googleforgames/agones/pull/3818](https://github.com/googleforgames/agones/pull/3818) - Skip /tmp/ on yamllint by [@​zmerlynn](https://github.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3838](https://github.com/googleforgames/agones/pull/3838) - TestAllocatorAfterDeleteReplica: More logging by [@​zmerlynn](https://github.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3837](https://github.com/googleforgames/agones/pull/3837) - Instructions for upgrading golang version by [@​gongmax](https://github.com/gongmax) in [https://github.com/googleforgames/agones/pull/3819](https://github.com/googleforgames/agones/pull/3819) - Remove unused function FindGameServerContainer by [@​zmerlynn](https://github.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3841](https://github.com/googleforgames/agones/pull/3841) - Adds Unreal to the List of URL Links to Not Check by [@​igooch](https://github.com/igooch) in [https://github.com/googleforgames/agones/pull/3847](https://github.com/googleforgames/agones/pull/3847) - docs: clarify virtualization setup for Windows versions by [@​andresromerodev](https://github.com/andresromerodev) in [https://github.com/googleforgames/agones/pull/3850](https://github.com/googleforgames/agones/pull/3850) **New Contributors:** - [@​skmpf](https://github.com/skmpf) made their first contribution in [https://github.com/googleforgames/agones/pull/3808](https://github.com/googleforgames/agones/pull/3808) - [@​yonbh](https://github.com/yonbh) made their first contribution in [https://github.com/googleforgames/agones/pull/3818](https://github.com/googleforgames/agones/pull/3818) - [@​peterzhongyi](https://github.com/peterzhongyi) made their first contribution in [https://github.com/googleforgames/agones/pull/3844](https://github.com/googleforgames/agones/pull/3844) - [@​andresromerodev](https://github.com/andresromerodev) made their first contribution in [https://github.com/googleforgames/agones/pull/3850](https://github.com/googleforgames/agones/pull/3850) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->
What type of PR is this?
What this PR does / Why we need it:
Nit fix on site documentation so that the firewall created has a name with the prefix "gke-" so that the GCE enforcer doesn't delete it. Also, include a reference link to the firewall creation in each pre-reqs. On the other hand, switched the order of cluster creation so that it defaults to Autopilot cluster creation first.
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: