Configure Allocator Status Code

[Kalaiselvi84]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3780

Special notes for your reviewer:

[agones-bot]

Build Failed 😱

Build Id: 6520f72f-8a86-4423-8f30-2041eb55cd95

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[zmerlynn]

Can we come up with an approach that doesn't involve flag interpretation in a base library? Flags should be plumbed down from the cmd/ layer.

[agones-bot]

Build Failed 😱

Build Id: da2f1075-c206-45c6-a938-67857a24e742

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[Kalaiselvi84]

Can we come up with an approach that doesn't involve flag interpretation in a base library? Flags should be plumbed down from the cmd/ layer.

I have moved the flag to cmd/main.go and updated the convertStateV1ToError in converter.go to use error code based on httpUnallocatedStatusCode and added a test in converter_test.go. Please review them and share your feedback..

[agones-bot]

Build Failed 😱

Build Id: e1ed79a1-811e-42cb-9699-8fb7464f31ca

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[zmerlynn]

Can we come up with an approach that doesn't involve flag interpretation in a base library? Flags should be plumbed down from the cmd/ layer.

I have moved the flag to cmd/main.go and updated the convertStateV1ToError in converter.go to use error code based on httpUnallocatedStatusCode and added a test in converter_test.go. Please review them and share your feedback..

It doesn't look like the flag was moved to cmd/main.go - rather, it looks like the flag was added there, and you added it to the config, but didn't do anything with that config? Your goal is to get to a place where there is no viper import in pkg/allocation at all - if you look, there's only a couple of places we do that, and in both cases we only import viper to provide a function that can be used in cmd/main.go for the respective binary.

I wish I could find a good citation for this, but the general idea here is that flags in libraries make testing a pain because they're "spooky action at a distance". Flags should go into config structures that get plumbed down.

But, that said, is there a reason not to do this directly here?

agones/cmd/allocator/main.go

Line 624 in 53a70b3

response, err := converters.ConvertGSAToAllocationResponse(allocatedGsa)

You can just look for ResourceExhausted and translate it to Unavailable right here instead.

[agones-bot]

Build Failed 😱

Build Id: dfcf3ca6-32aa-468d-8b76-c0c8fcb6bb40

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: 2cab87d3-f833-49f2-acc8-74f1695703be

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[Kalaiselvi84]

Flags should go into config structures that get plumbed down.

But, that said, is there a reason not to do this directly here?

agones/cmd/allocator/main.go

Line 624 in 53a70b3

response, err := converters.ConvertGSAToAllocationResponse(allocatedGsa)

Along with adding a new flag in the config structures, I've also integrated it into the newServiceHandler() function and within the Allocate() method of the serviceHandler, this statusCode is utilized when calling ConvertGSAToAllocationResponse() method and modified the converter.go file to capture this change. Please let me know if I am in the right direction and share your feedback..

[agones-bot]

Build Failed 😱

Build Id: 397afe29-88a6-48e6-a9f9-70dca07d5e84

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[zmerlynn]

This is actually looking pretty solid, just a nit

[agones-bot]

Build Failed 😱

Build Id: 4721c5c9-8448-415f-a4f1-2d0762a683a0

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: 00de5ace-072e-4299-9b35-b506a7c5c63b

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: 22f82971-322e-485a-bb14-be9f0bd076d1

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: e5f49c79-e4b4-41b0-bfb4-4056425957e1

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[zmerlynn]

Very close!

[agones-bot]

Build Succeeded 👏

Build Id: 2bb930ab-f69b-4b59-a828-1f24ae348345

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.41.0-dev-e6716e9-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.41.0-dev-e6716e9-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.41.0-dev-e6716e9-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.41.0-dev-e6716e9-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.41.0-dev-e6716e9-amd64
• Linux C++ SDK (build): agonessdk-1.41.0-dev-e6716e9-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.41.0-dev-e6716e9-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://e6716e9-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3782/head:pr_3782 && git checkout pr_3782
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-e6716e9-amd64