Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agones-{extensions,allocator}: Pause after cancelling context #3843

Merged
merged 3 commits into from
May 30, 2024

Commits on May 29, 2024

  1. Configuration menu
    Copy the full SHA
    faf02b3 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. agones-{extensions,allocator}: Pause after cancelling context

    After googleforgames#3839 went in, we noticed the flakes in
    TestAllocatorAfterDeleteReplica disappear, but
    TestGameServerCreationRightAfterDeletingOneExtensionsPod remained. I
    looked more closely at this and I developed a theory: My guess is that
    `kube-apiserver` connections to webhooks are actually "sticky" using
    http(s) keepalives. If the TCP connection never closes, we'd see the
    behavior we do, which is the `EOF` from kube-apiserver going to write
    on a dead socket.
    
    I looked at how to close sockets on the server side to "finish" the
    drain, but realized that we actually do, by cancelling the context.
    The thing is that we cancel the context and immediately exit, but it
    leaves no time for anything to shut down.
    
    I tested this and it seems to drive away the flake, without adding in
    the extra delay.
    
    Reverts googleforgames#3839
    zmerlynn committed May 30, 2024
    Configuration menu
    Copy the full SHA
    6dda265 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    90dcbf2 View commit details
    Browse the repository at this point in the history