Update csharp.md to indicate ConnectAsync is deprecated

[aallbrig]

What type of PR is this?
/kind documentation

What this PR does / Why we need it:
As I was following the AgonesSDK C# guide I noticed that when I tried using ConnectAsync the function has actually been deprecated. It'd be good to get verbiage into the documentation so other Agones users know they don't have to use this method any longer.

Source @ agones/sdks/csharp/sdk/AgonesSDK.cs#112

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:
Unsure if a strike through is desired or if the documentation block should just be completely removed. Let me know what you'd prefer. If I don't respond quickly enough please feel free to take on the documentation changes outside this PR.

[agones-bot]

Build Succeeded 👏

Build Id: e624feb0-630a-457f-9942-11be0abf45ec

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.42.0-dev-5b6584a-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.42.0-dev-5b6584a-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.42.0-dev-5b6584a-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.42.0-dev-5b6584a-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.42.0-dev-5b6584a-amd64
• Linux C++ SDK (build): agonessdk-1.42.0-dev-5b6584a-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.42.0-dev-5b6584a-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://5b6584a-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3866/head:pr_3866 && git checkout pr_3866
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-5b6584a-amd64

[markmandel]

@igooch , @zmerlynn - given the new SDK compatibility standards, I think we can delete this ConnectAsync function from the C# SDK, since it actually does nothing?

Or since it was implemented 9 months ago, we have to wait another 3 months?

[igooch]

We guarantee the SDK Server compatibility, not the Client SDK implementation, so we're technically fine to remove it.

[markmandel]

We guarantee the SDK Server compatibility, not the Client SDK implementation, so we're technically fine to remove it.

Sounds like - this PR should delete the method entirely (label as kind/breaking) and update the SDK docs to feature shortcode hide the SDK method for the next version of Agones.

What do we think?

[zmerlynn]

We guarantee the SDK Server compatibility, not the Client SDK implementation, so we're technically fine to remove it.

Sounds like - this PR should delete the method entirely (label as kind/breaking) and update the SDK docs to feature shortcode hide the SDK method for the next version of Agones.

What do we think?

Agreed.

[markmandel]

@aallbrig - you up for this change? 😄

[aallbrig]

Yes!

…

On Thu, Jun 13, 2024 at 6:10 PM Mark Mandel ***@***.***> wrote: @aallbrig <https://github.com/aallbrig> - you up for this change? 😄 — Reply to this email directly, view it on GitHub <#3866 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXWLSQJJPHX5UZ4UGR2OILZHIKF3AVCNFSM6AAAAABJEVG7V6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRWHA3TMOJYG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[agones-bot]

Build Succeeded 👏

Build Id: 213a5d1e-fedc-44ae-98e8-c27e2dc0b0ec

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.42.0-dev-4d77f76-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.42.0-dev-4d77f76-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.42.0-dev-4d77f76-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.42.0-dev-4d77f76-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.42.0-dev-4d77f76-amd64
• Linux C++ SDK (build): agonessdk-1.42.0-dev-4d77f76-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.42.0-dev-4d77f76-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://4d77f76-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3866/head:pr_3866 && git checkout pr_3866
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-4d77f76-amd64

[aallbrig]

@markmandel this change is ready to re-review!

[igooch]

Overall looks good. There's a line towards the bottom of the csharp.md file - All requests other than ConnectAsync will wait for up to 15 seconds before giving up, time to wait can also be set in the constructor.. You can modify similar to how you did with {{% feature expiryVersion="1.42.0" %}}.

[aallbrig]

@igooch Added in suggested commits and added the expiry feature flag around ConnectAsync remark. Merged latest from main. Thanks for reviewing!

[agones-bot]

Build Failed 😱

Build Id: 945a6c44-33d8-4429-9420-0e3df838a1c5

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[igooch]

One last item then LGTM.

[agones-bot]

Build Succeeded 👏

Build Id: c008d695-a615-4465-b5e3-a702b55eaed7

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.42.0-dev-01f6951-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.42.0-dev-01f6951-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.42.0-dev-01f6951-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.42.0-dev-01f6951-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.42.0-dev-01f6951-amd64
• Linux C++ SDK (build): agonessdk-1.42.0-dev-01f6951-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.42.0-dev-01f6951-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://01f6951-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3866/head:pr_3866 && git checkout pr_3866
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-01f6951-amd64

[igooch]

LGTM, thanks!

[agones-bot]

Build Succeeded 👏

Build Id: 59e2cb1f-4df2-4497-a3f2-0053990a8b0d

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.42.0-dev-7658296-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.42.0-dev-7658296-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.42.0-dev-7658296-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.42.0-dev-7658296-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.42.0-dev-7658296-amd64
• Linux C++ SDK (build): agonessdk-1.42.0-dev-7658296-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.42.0-dev-7658296-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://7658296-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3866/head:pr_3866 && git checkout pr_3866
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-7658296-amd64