Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add CRD Changes and Feature Flag for chain policy #3880

Merged
merged 32 commits into from
Jul 10, 2024
Merged

feat: Add CRD Changes and Feature Flag for chain policy #3880

merged 32 commits into from
Jul 10, 2024

Conversation

indexjoseph
Copy link
Contributor

@indexjoseph indexjoseph commented Jun 24, 2024 •
edited by zmerlynn
Loading

What type of PR is this?

/kind feature

What this PR does / Why we need it:
New Chain Policy for Scheduled Autoscaling, see this comment for more info: comment

Which issue(s) this PR fixes:
Towards #3008

Special notes for your reviewer:

@github-actions github-actions bot added the kind/feature New features for Agones label Jun 24, 2024
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 400ce682-b083-4f58-91a9-d32f9d48b6ce

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@indexjoseph indexjoseph changed the title feat: Scheduled Autoscalers feat: CRD Changes for new fleetautoscaler chain policy Jun 24, 2024
@indexjoseph indexjoseph changed the title feat: CRD Changes for new fleetautoscaler chain policy feat: Add CRD Changes for chain policy Jun 24, 2024
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: aab7f190-0879-4b03-8390-90bc8f85a610

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@zmerlynn
Copy link
Collaborator

A couple of things:

  1. This should be under a feature gate, including the CRD addition (the refactor portion should be fine, but the new additions should be gated). See here for how to add a gate: https://github.com/googleforgames/agones/blob/main/pkg/util/runtime/features.go#L85 .. but also, you can gate helm values, see

    agones/install/helm/agones/templates/controller.yaml

    Lines 118 to 119 in 1f6b2a0

    {{- $featureGates := include "agones.featureGates" . | fromYaml }}
    {{- if not $featureGates.PortRanges }}
    for a recent example. Doing all of this under a dev feature gate will allow you to send smaller PRs without it all being ready for testing yet.
  2. Split this up into smaller PRs - feel free to submit the validation separate from the CRD itself, since they're both big hunks to review.

@indexjoseph indexjoseph changed the title feat: Add CRD Changes for chain policy feat: Add CRD Changes and Feature Flag for chain policy Jun 24, 2024
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8db36c7c-204e-4960-b4a1-e6522102f1a8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c35a15cf-dfce-4e97-9e4e-6e60ebdb5ff4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b580612f-a992-4f15-847f-c66660edaa69

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e5b70ed5-2ca7-4494-bcfb-d25c47fed13e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3880/head:pr_3880 && git checkout pr_3880
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-bf4b616-amd64

@indexjoseph indexjoseph marked this pull request as ready for review June 25, 2024 21:56
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bf88ff90-81b7-4469-8ed1-137103bf2a9d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3880/head:pr_3880 && git checkout pr_3880
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-f494f3c-amd64

This was referenced Jul 3, 2024
Closed
Merged
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f9a0471d-b216-4045-a687-06fe3c865d24

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d4beaa90-e177-4d79-b408-88b8c3344d3f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e2793105-fe2f-4579-93cf-144666a022a9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3880/head:pr_3880 && git checkout pr_3880
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-13e4e77-amd64

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a9fcd094-59d4-4f16-b542-1786ac8c878a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 11f4dff3-cbb3-4aca-8d51-c27835709d93

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3880/head:pr_3880 && git checkout pr_3880
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-c96d80b-amd64

zmerlynn
zmerlynn reviewed Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@zmerlynn zmerlynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a second or redundant comment, I'm sorry - I see I have two review comments but can only see one.

examples/chainfleetautoscaler.yaml Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7035dff9-fcc5-4a49-9b39-3b6e74a3f0cb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3880/head:pr_3880 && git checkout pr_3880
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-59c4259-amd64

zmerlynn
zmerlynn approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@zmerlynn zmerlynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@zmerlynn zmerlynn enabled auto-merge (squash) July 10, 2024 00:14
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: dd93fdcd-8b19-4d12-82f7-348aaee568b7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3880/head:pr_3880 && git checkout pr_3880
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-6a49905-amd64

@zmerlynn zmerlynn merged commit a1a031c into googleforgames:main Jul 10, 2024
4 checks passed
spiceratops referenced this pull request in spiceratops/k8s-gitops Jul 23, 2024
@spiceratops
feat(helm): update chart agones to 1.42.0 (#859)
6613a6b 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [agones](https://agones.dev)
([source](https://github.com/googleforgames/agones)) | minor |
`1.41.0` -> `1.42.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>googleforgames/agones (agones)</summary>

###
[`v1.42.0`](https://github.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1420-2024-07-16)

[Compare
Source](https://github.com/googleforgames/agones/compare/v1.41.0...v1.42.0)

[Full
Changelog](https://github.com/googleforgames/agones/compare/v1.41.0...v1.42.0)

**Breaking changes:**

- Update csharp.md to indicate ConnectAsync is deprecated by
[@&#8203;aallbrig](https://github.com/aallbrig) in
[https://github.com/googleforgames/agones/pull/3866](https://github.com/googleforgames/agones/pull/3866)

**Implemented enhancements:**

- Add security context to Agones containers by
[@&#8203;peterzhongyi](https://github.com/peterzhongyi) in
[https://github.com/googleforgames/agones/pull/3856](https://github.com/googleforgames/agones/pull/3856)
- Add Security Context to game server sidecar by
[@&#8203;peterzhongyi](https://github.com/peterzhongyi) in
[https://github.com/googleforgames/agones/pull/3869](https://github.com/googleforgames/agones/pull/3869)
- Drop CountsAndLists Data from the Fleet and Game Server Set When the
Flag is False by [@&#8203;igooch](https://github.com/igooch) in
[https://github.com/googleforgames/agones/pull/3881](https://github.com/googleforgames/agones/pull/3881)
- Adds tests to confirm that Fleet, Fleet Autoscaler, and Fleet
Allocation apply defaults code is idempotent by
[@&#8203;igooch](https://github.com/igooch) in
[https://github.com/googleforgames/agones/pull/3888](https://github.com/googleforgames/agones/pull/3888)
- feat: Add CRD Changes and Feature Flag for chain policy by
[@&#8203;indexjoseph](https://github.com/indexjoseph) in
[https://github.com/googleforgames/agones/pull/3880](https://github.com/googleforgames/agones/pull/3880)

**Fixed bugs:**

- sdk-server expects SDK_LOG_LEVEL by
[@&#8203;KAllan357](https://github.com/KAllan357) in
[https://github.com/googleforgames/agones/pull/3858](https://github.com/googleforgames/agones/pull/3858)
- this will resolve From/layer extraction issue on ltsc2019 in examples
by [@&#8203;ashutosji](https://github.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3873](https://github.com/googleforgames/agones/pull/3873)
- featuregate: adds validation if PortPolicyNone is not enabled by
[@&#8203;daniellee](https://github.com/daniellee) in
[https://github.com/googleforgames/agones/pull/3871](https://github.com/googleforgames/agones/pull/3871)
- added local as default for registry when registry is not specified by
[@&#8203;kamaljeeti](https://github.com/kamaljeeti) in
[https://github.com/googleforgames/agones/pull/3876](https://github.com/googleforgames/agones/pull/3876)
- Buffer Unity SDK ReceiveData when watching for configuration changes
by [@&#8203;ZeroParticle](https://github.com/ZeroParticle) in
[https://github.com/googleforgames/agones/pull/3872](https://github.com/googleforgames/agones/pull/3872)
- agones-{extensions,allocator}: Make servers context aware by
[@&#8203;zmerlynn](https://github.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3845](https://github.com/googleforgames/agones/pull/3845)
- added condition for distributed logic by
[@&#8203;ashutosji](https://github.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3877](https://github.com/googleforgames/agones/pull/3877)

**Security fixes:**

- Bump [@&#8203;grpc/grpc-js](https://github.com/grpc/grpc-js) from
1.10.7 to 1.10.9 in /sdks/nodejs by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/googleforgames/agones/pull/3863](https://github.com/googleforgames/agones/pull/3863)

**Other:**

- Preparation for Release v1.42.0 by
[@&#8203;ashutosji](https://github.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3854](https://github.com/googleforgames/agones/pull/3854)
- Add helpful note to edit-first-gameserver-go by
[@&#8203;peterzhongyi](https://github.com/peterzhongyi) in
[https://github.com/googleforgames/agones/pull/3846](https://github.com/googleforgames/agones/pull/3846)
- Moved Passthrough feature description to the correct section in
Feature Stages by [@&#8203;vicentefb](https://github.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3861](https://github.com/googleforgames/agones/pull/3861)
- Updated Node.js Page to Reflect that Counters and Lists is Implemented
by [@&#8203;ashutosji](https://github.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3865](https://github.com/googleforgames/agones/pull/3865)
- Change Slack channel description from #developers to #development by
[@&#8203;branhoff](https://github.com/branhoff) in
[https://github.com/googleforgames/agones/pull/3868](https://github.com/googleforgames/agones/pull/3868)
- updated UpdateList documentation for local sdk server and sdk server
by [@&#8203;ashutosji](https://github.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3878](https://github.com/googleforgames/agones/pull/3878)
- Add zio-agones to the list of third party client SDKs by
[@&#8203;ghostdogpr](https://github.com/ghostdogpr) in
[https://github.com/googleforgames/agones/pull/3875](https://github.com/googleforgames/agones/pull/3875)
- refactor simple game server by
[@&#8203;ashutosji](https://github.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3817](https://github.com/googleforgames/agones/pull/3817)
- Update Slack invite link by
[@&#8203;markmandel](https://github.com/markmandel) in
[https://github.com/googleforgames/agones/pull/3896](https://github.com/googleforgames/agones/pull/3896)
- Added cleanup for app-engine services in cloudbuild script by
[@&#8203;kamaljeeti](https://github.com/kamaljeeti) in
[https://github.com/googleforgames/agones/pull/3890](https://github.com/googleforgames/agones/pull/3890)
- Adds a command to generate the zz_generated.deepcopy.go files for the
apis by [@&#8203;igooch](https://github.com/igooch) in
[https://github.com/googleforgames/agones/pull/3900](https://github.com/googleforgames/agones/pull/3900)
- update go version to 1.21.12 by
[@&#8203;ashutosji](https://github.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3894](https://github.com/googleforgames/agones/pull/3894)

**New Contributors:**

- [@&#8203;KAllan357](https://github.com/KAllan357) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3858](https://github.com/googleforgames/agones/pull/3858)
- [@&#8203;branhoff](https://github.com/branhoff) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3868](https://github.com/googleforgames/agones/pull/3868)
- [@&#8203;aallbrig](https://github.com/aallbrig) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3866](https://github.com/googleforgames/agones/pull/3866)
- [@&#8203;ZeroParticle](https://github.com/ZeroParticle) made their
first contribution in
[https://github.com/googleforgames/agones/pull/3872](https://github.com/googleforgames/agones/pull/3872)
- [@&#8203;ghostdogpr](https://github.com/ghostdogpr) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3875](https://github.com/googleforgames/agones/pull/3875)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->
@vicentefb vicentefb mentioned this pull request Oct 15, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicentefb vicentefb vicentefb left review comments

@markmandel markmandel markmandel left review comments

@zmerlynn zmerlynn zmerlynn approved these changes

Assignees
No one assigned
Labels
kind/feature New features for Agones size/L size/M size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@indexjoseph @agones-bot @zmerlynn @markmandel @vicentefb