Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for running Agones on Minikube with the Windows Docker driver #3965

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

brightestpixel
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / Why we need it:

This PR adds new instructions on how to connect to GameServers using Minikube's default Docker driver on Windows and without too much extra setup (no extra services per GameServer, minikube tunnel, etc.). This should improve the developer experience for those wanting to use Minikube on Windows to test out their GameServers.

The solution is to publish the ports that Agones uses through the minikube start command and let Docker forward connections to Minikube and any GameServers. This workaround has worked well on both Windows systems where I have tried it.

Which issue(s) this PR fixes: N/A

Special notes for your reviewer:

I'm not an expert on container networking, so if anyone has comments on this approach I'd love to hear them!

@github-actions github-actions bot added kind/documentation Documentation for Agones size/S labels Aug 24, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: fd5a88e7-b1f5-41e5-8bc7-971aaa37ca6a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3965/head:pr_3965 && git checkout pr_3965
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-ddfb866

Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the additional testing and documentation.

@igooch igooch enabled auto-merge (squash) September 9, 2024 03:50
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 4b371c88-78b6-489e-99dd-4b6d3bae376b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3965/head:pr_3965 && git checkout pr_3965
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-ffd5ddd

@igooch igooch merged commit f6d81e6 into googleforgames:main Sep 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Documentation for Agones size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants