Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all Rust SDK dependencies to latest versions #4008

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

john-haven
Copy link
Contributor

@john-haven john-haven commented Oct 2, 2024

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

The API tonic_build::configure::compile::compile_protos was renamed as part of this crate upgrade
prost v0.13.3 requires rustc 1.71.1 or newer

The API `tonic_build::configure::compile::compile_protos` was renamed as part of this crate upgrade
@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/S labels Oct 2, 2024
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: fbd02dc6-fddc-4b51-a8aa-5068f29690b5

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

prost v0.13.3 requires rustc 1.71.1 or newer
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 79e2b25d-701a-463c-a01e-008c645f3f47

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 1ee41e6a-d123-4373-8b09-f60943c488f7

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 35000729-11eb-4414-8f01-71f2211bd628

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@john-haven john-haven marked this pull request as draft October 2, 2024 21:47
@john-haven
Copy link
Contributor Author

I don't really understand the build failure here

@markmandel
Copy link
Member

markmandel commented Oct 8, 2024

6.232 Package python is not available, but is referred to by another package.
6.232 This may mean that the package is missing, has been obsoleted, or
6.232 is only available from another source
6.232 However the following packages replace it:
6.232   2to3 python2-minimal python2 dh-python python-is-python3
6.232 
6.235 E: Package 'python' has no installation candidate
------
ERROR: failed to solve: executor failed running [/bin/sh -c apt-get update &&     apt-get install -y wget psmisc make gcc python jq zip &&     apt-get clean]: exit code: 100

That's a weird one. Maybe change to python3 ?

@gongmax
Copy link
Collaborator

gongmax commented Oct 8, 2024

6.232 Package python is not available, but is referred to by another package.
6.232 This may mean that the package is missing, has been obsoleted, or
6.232 is only available from another source
6.232 However the following packages replace it:
6.232   2to3 python2-minimal python2 dh-python python-is-python3
6.232 
6.235 E: Package 'python' has no installation candidate
------
ERROR: failed to solve: executor failed running [/bin/sh -c apt-get update &&     apt-get install -y wget psmisc make gcc python jq zip &&     apt-get clean]: exit code: 100

That's a weird one. Maybe change to python3 ?

I already merged a fix for it #4009 , the retry should succeed

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 74d058ea-d237-4dfb-8b82-d2be192b6f08

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4008/head:pr_4008 && git checkout pr_4008
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-6fd359a

@john-haven john-haven marked this pull request as ready for review October 8, 2024 17:57
@gongmax gongmax enabled auto-merge (squash) October 9, 2024 18:22
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: c8f8b677-6d3a-4719-a50a-4b03156d59e2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4008/head:pr_4008 && git checkout pr_4008
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-c81f87c

@gongmax gongmax merged commit a27aeab into googleforgames:main Oct 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants