Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cpp-simple example tag to 0.19 #4040

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

kamaljeeti
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/XS labels Nov 19, 2024
@kamaljeeti kamaljeeti changed the title update cpp-simple example tag to 0.19 Update cpp-simple example tag to 0.19 Nov 19, 2024
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: eb24a3da-3eba-4194-85ec-e8b3eb179cbe

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 3e102545-998d-4e1a-b4f2-e0e2fc0f7029

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 9fac76ef-1b53-4fd6-95e1-5b83ffcceb55

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@gongmax
Copy link
Collaborator

gongmax commented Nov 19, 2024

check-example-versions failed. Seems this CI check doesn't work as expect, it doesn't exclude the *yaml files from checking.

@gongmax
Copy link
Collaborator

gongmax commented Nov 19, 2024

The PR LGTM, I'm force merging it, and create a issue to debug the CI check failure.

@gongmax gongmax merged commit 0f9823e into googleforgames:main Nov 19, 2024
3 of 4 checks passed
0xaravindh pushed a commit to 0xaravindh/agones that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants