Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fleet name to gameservers labels #427

Merged
merged 2 commits into from
Nov 28, 2018
Merged

add fleet name to gameservers labels #427

merged 2 commits into from
Nov 28, 2018

Conversation

cyriltovena
Copy link
Collaborator

@cyriltovena cyriltovena commented Nov 27, 2018 •
edited
Loading

This adds fleet name to gameservers, I've renamed the label to be more general.

I don't think I've forgot anything let me know. I needed this also for metrics.

Closes #411

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 02a431e3-3c1a-49a5-8972-6550e48027a7

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/427/head:pr_427 && git checkout pr_427
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.6.0-3160a91

@markmandel markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Nov 27, 2018
markmandel
markmandel approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/performance Anything to do with Agones being slow, or making it go faster. and removed feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Nov 28, 2018
@markmandel markmandel added this to the 0.7.0 milestone Nov 28, 2018
@markmandel
Copy link
Member

If you need this urgently, please feel free to merge - i wouldn't mind having #430 merge first, just for ordering, but I'm not strongly wedded to it.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a219819d-25dc-4092-b0c3-25caebad9c57

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/427/head:pr_427 && git checkout pr_427
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.6.0-4fb49cd

@cyriltovena cyriltovena merged commit caaba8a into googleforgames:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/performance Anything to do with Agones being slow, or making it go faster. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cyriltovena @agones-bot @markmandel