-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds OpenCensus metrics integration. #457
Adds OpenCensus metrics integration. #457
Conversation
Build Failed 😱 Build Id: 1eb0ddc2-03ce-46a0-bef1-d7cf474740dd Build Logs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good 😄 coupl'a small things I saw in there I was curious about.
Will take it for a spin on stackdriver at some point in the near future as well!
ec77b2a
to
b823280
Compare
Build Failed 😱 Build Id: 630734a8-601c-47dc-8bf3-74a9bc6f3680 Build Logs
|
I've fixes tests races but it got me thinking. Should I always |
b823280
to
5d5a0e6
Compare
Build Succeeded 👏 Build Id: eb503984-8ff6-4bb4-be23-c1ca42d2f363 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
Do you mean |
5d5a0e6
to
67a7c71
Compare
Build Succeeded 👏 Build Id: c1196817-a885-4049-be55-62a031ba001e The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran into a blocking issue.
Also wondering how this passed the tests?
Yeeps - yep, e2e actually didn't fail when it was supposed to!
|
67a7c71
to
233e774
Compare
Build Failed 😱 Build Id: f18fdca8-9521-4137-ab4f-fe9e4bcdb157 Build Logs
|
233e774
to
8ecb353
Compare
Build Succeeded 👏 Build Id: c512bba7-fe1e-45fb-ba7d-ec3f2099a557 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this going! 🙆♂️
Got some conflicts, but I think I can resolve them in the browser.
- First set of metrics added using informers cache. - Added flag for switching off metrics via helm and env vars. - Added a documentation section about metrics and usage.
8ecb353
to
46242fb
Compare
Build Succeeded 👏 Build Id: f81385e9-fa83-4445-83c9-07d40a7ef54e The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
Merry Christmas Agones,
This is my present 🎅 🎄 🎁 .
This PR moves forward #144
Next steps should be: