Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade minikube to K8s 1.11 #459

Merged
merged 3 commits into from
Dec 28, 2018
Merged

Upgrade minikube to K8s 1.11 #459

merged 3 commits into from
Dec 28, 2018

Conversation

markmandel
Copy link
Member

Whoops, missed this change in the 1.11 upgrade.

@markmandel
Upgrade minikube to K8s 1.11
38d3aff 
Whoops, missed this change in the 1.11 upgrade.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Dec 26, 2018
@markmandel markmandel added this to the 0.7.0 milestone Dec 26, 2018
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 38fc8847-01c8-4368-b175-8a653bedd3e5

The following development artifacts have been built, and will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/459/head:pr_459 && git checkout pr_459
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.7.0-38d3aff

cyriltovena
cyriltovena approved these changes Dec 28, 2018
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's related but I can't get e2e works because of the ping service not reachable.

Other than that LGTM

@markmandel
Copy link
Member Author

Ah - I think that's a Linux/OSX differencec. @EricFortin had some hack for setting the ip the same across minikube and the local machine (or something?)? Maybe we should bake that into the osx version of minikube-test-cluster ?

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ac9793cf-5549-4a92-906a-41e58255ebb0

The following development artifacts have been built, and will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/459/head:pr_459 && git checkout pr_459
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.7.0-0441a51

@markmandel markmandel merged commit b492850 into googleforgames:master Dec 28, 2018
@markmandel markmandel deleted the cleanup/minikube-1.11 branch December 28, 2018 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @cyriltovena