Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This should fail e2e in any command fails #462

Merged
merged 2 commits into from
Dec 27, 2018
Merged

This should fail e2e in any command fails #462

merged 2 commits into from
Dec 27, 2018

Conversation

markmandel
Copy link
Member

In the current incarnation, if the install section fails, and e2e passes, then e2e all passes.

This should fail now if install fails.

@markmandel
This should fail e2e in any command fails
051d9fb 
In the current incarnation, if the install section
fails, and e2e passes, then e2e all passes.

This should fail now if install fails.
@markmandel markmandel added kind/bug These are bugs. area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Dec 27, 2018
@markmandel markmandel added this to the 0.7.0 milestone Dec 27, 2018
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 02b5c2f2-b2c1-402a-a4b9-869e2d89a9db

The following development artifacts have been built, and will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/462/head:pr_462 && git checkout pr_462
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.7.0-051d9fb

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2ebdece7-87dd-4eb5-99a5-28ee8c3f8ef7

The following development artifacts have been built, and will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/462/head:pr_462 && git checkout pr_462
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.7.0-2394486

@markmandel markmandel merged commit 0aa496d into googleforgames:master Dec 27, 2018
@markmandel markmandel deleted the build/fail-e2e-on-install branch December 27, 2018 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/bug These are bugs.
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @cyriltovena