Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to using Fluentdformatter #463

Merged
merged 1 commit into from
Dec 28, 2018
Merged

Convert to using Fluentdformatter #463

merged 1 commit into from
Dec 28, 2018

Conversation

markmandel
Copy link
Member

This is the technically correct implementation for Fluentd and for GKE.

Closes #456

@markmandel
Convert to using Fluentdformatter
3ca0554 
This is the technically correct implementation
for Fluentd and for GKE.

Closes googleforgames#456
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Dec 28, 2018
@markmandel markmandel added this to the 0.7.0 milestone Dec 28, 2018
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: dfce1570-d78d-495e-ba79-de6b41bfedac

The following development artifacts have been built, and will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/463/head:pr_463 && git checkout pr_463
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.7.0-3ca0554

cyriltovena
cyriltovena approved these changes Dec 28, 2018
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel markmandel merged commit 018972d into googleforgames:master Dec 28, 2018
@markmandel markmandel deleted the bug/fluentd-formatter branch December 28, 2018 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @cyriltovena