-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix autoscaler cleanup on tests failure #474
Conversation
Build Failed 😱 Build Id: 35daaa92-c71a-40e8-bfb4-7f631c6c4d7b Build Logs
|
efe6062
to
a98254d
Compare
Build Succeeded 👏 Build Id: e4a4eb4a-a96b-425f-a88d-39456a102470 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
Thought: should we also put a delete all FleetAllocations in the TestMain() like we do for Fleets and GameServers? |
Sure I’ll add it EDIT: Voila ! |
add more cleanup
a98254d
to
0d13cbe
Compare
Build Succeeded 👏 Build Id: 347cfd35-6287-4336-8998-c19131676f47 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Build Succeeded 👏 Build Id: 749bdd2f-dd0b-4729-997a-cfc0545d18c2 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
Closes #471
It seems to be happening only when tests are failing.