Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve docker layers using COPY --chown #482

Merged
merged 1 commit into from
Jan 9, 2019
Merged

improve docker layers using COPY --chown #482

merged 1 commit into from
Jan 9, 2019

Conversation

cyriltovena
Copy link
Collaborator

Closes #481

After following suggestions, I'm having:

gcr.io/agones-images/agones-ping              0.8.0-9646141     18.9MB
gcr.io/agones-images/agones-sdk               0.8.0-9646141      42.7MB
gcr.io/agones-images/agones-controller        0.8.0-9646141    44.5MB

compared to previously:

gcr.io/agones-images/agones-ping              0.7.0-f3cb1ee  31.6MB
gcr.io/agones-images/agones-sdk               0.7.0-f3cb1ee   78.9MB
gcr.io/agones-images/agones-controller        0.7.0-f3cb1ee 82.5MB

@Oleksii-Terekhov @aLekSer Good catch guys !

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fb4478e0-d3df-4418-b010-89c5ba879730

The following development artifacts have been built, and will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/482/head:pr_482 && git checkout pr_482
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-dc48f9e

markmandel
markmandel approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markmandel markmandel merged commit 6cb002e into googleforgames:master Jan 9, 2019
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc labels Jan 9, 2019
@markmandel markmandel added this to the 0.8.0 milestone Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cyriltovena @agones-bot @markmandel