Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for the controller panic issue on metrics.enabled is false #486

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Fix for the controller panic issue on metrics.enabled is false #486

merged 1 commit into from
Jan 17, 2019

Commits on Jan 16, 2019

  1. Fix for the issue when metrics.enabled is false 

    If we disable metrics in Helm config file, Agones controller
will panic on rr.Run() which could not be executed on non-nil interface
with nil value (and not empty type of metrics.Controller).
    @aLekSer
    aLekSer committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    caae253 View commit details
    Browse the repository at this point in the history