Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reflect from controller. #488

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Remove reflect from controller. #488

merged 1 commit into from
Jan 17, 2019

Conversation

markmandel
Copy link
Member

Just some cleanup, Sprintf("%T") is nicer.

@markmandel
Remove reflect from controller.
6ad6cdf 
Just some cleanup, Sprintf("%T") is nicer.
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Jan 17, 2019
@markmandel markmandel added this to the 0.8.0 milestone Jan 17, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3ddc33e6-1253-46af-ad61-067b11c1767a

The following development artifacts have been built, and will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/488/head:pr_488 && git checkout pr_488
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-6ad6cdf

cyriltovena
cyriltovena approved these changes Jan 17, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel markmandel merged commit 529448f into googleforgames:master Jan 17, 2019
@markmandel markmandel deleted the cleanup/sprintf branch January 17, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @cyriltovena