Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: allowed 'go test' to run without docker and optionally w/o race detector #509

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Makefile: allowed 'go test' to run without docker and optionally w/o race detector #509

merged 1 commit into from
Jan 29, 2019

Conversation

jkowalski
Copy link
Contributor

This is triggered by LOCAL_GO=1 and NO_RACE_DETECTOR=1 respectively.

@markmandel markmandel added the area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. label Jan 25, 2019
cyriltovena
cyriltovena approved these changes Jan 28, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel markmandel added the kind/feature New features for Agones label Jan 28, 2019
@markmandel
Copy link
Member

@jkowalski can you please resolve the conflicts on your end - not sure which way this should be. 👍

@jkowalski
Copy link
Contributor Author

jkowalski commented Jan 29, 2019 •
edited
Loading

Resolved, it was a super messy merge for some weird reason.

@jkowalski
Makefile: allowed 'go test' to run without docker and optionally w/o …
97974de 
…race detector

This is triggered by LOCAL_GO=1 and NO_RACE_DETECTOR=1 respectively.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 35374c97-1aeb-4117-9e3f-71ceb0996ea9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/509/head:pr_509 && git checkout pr_509
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-97974de

@markmandel markmandel merged commit 70410b8 into googleforgames:master Jan 29, 2019
@markmandel markmandel added this to the 0.8.0 milestone Jan 30, 2019
@WontonSam WontonSam mentioned this pull request Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/feature New features for Agones
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jkowalski @markmandel @agones-bot @cyriltovena