Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PortAllocator.Run() is no longer blocking. #531

Merged
merged 1 commit into from
Jan 30, 2019
Merged

PortAllocator.Run() is no longer blocking. #531

merged 1 commit into from
Jan 30, 2019

Conversation

markmandel
Copy link
Member

We no longer need the goroutine, so cleaning it up.

@markmandel
PortAllocator.Run() is no longer blocking.
bdccd7c 
We no longer need the goroutine, so cleaning it up.
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Jan 30, 2019
@markmandel markmandel added this to the 0.8.0 milestone Jan 30, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c0e5b254-3306-42cb-beab-2529c9ce0c68

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/531/head:pr_531 && git checkout pr_531
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-bdccd7c

@jkowalski jkowalski merged commit beba965 into googleforgames:master Jan 30, 2019
@markmandel markmandel deleted the cleanup/portallocator branch January 30, 2019 18:34
@WontonSam WontonSam mentioned this pull request Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowalski jkowalski jkowalski approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @jkowalski