Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed kubeInformation to kubeInformer. #545

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Changed kubeInformation to kubeInformer. #545

merged 1 commit into from
Feb 1, 2019

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented Feb 1, 2019

No description provided.

markmandel
markmandel approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SMH, how did I do that everywhere? 😞

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f0375a2d-9b33-4c8f-a47c-83424a623dd3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7cb2fec9-72f9-4c1f-a19d-7cd0686fbe6a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/545/head:pr_545 && git checkout pr_545
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-13c62c2

@markmandel markmandel merged commit 41d6656 into googleforgames:master Feb 1, 2019
@pooneh-m
Copy link
Contributor Author

pooneh-m commented Feb 1, 2019

SMH, how did I do that everywhere?

When you are too productive that happens ;)
Thank you. That gave me opportunity to contribute to the repo eaaaaaaasily.

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Feb 5, 2019
@markmandel markmandel added this to the 0.8.0 milestone Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pooneh-m @agones-bot @markmandel