Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stackdriver distribution without bucket bounds #554

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Feb 4, 2019

New k8s metrics results in error in Stackdriver exporter. In order to
fix it we need to define two infinite buckets with a delimiter of 0.
Fix was verified in Stackdriver dashboard.

Fix was proposed here

The documentation is here: https://godoc.org/go.opencensus.io/stats/view#Distribution . 
The problem is although OpenCensus allows Distribution with no bucket bounds,
 Stackdriver doesn't support it.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0d3a2749-ffbf-45e7-b6b2-7886e7471dd9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/554/head:pr_554 && git checkout pr_554
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-3a88e45

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 47fb6b3b-a8e5-4ba0-838d-5bfec6cc35e3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/554/head:pr_554 && git checkout pr_554
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-9eb507a

Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

New k8s metrics results in error in Stackdriver exporter. In order to
fix it we need to define two infinite buckets with a delimiter of 0.
Fix was verified in Stackdriver dashboard.
@aLekSer
Copy link
Collaborator Author

aLekSer commented Feb 4, 2019

I have made a rebase and rebuild with the latest master, still able to see metrics in Stackdriver.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5c06b571-2274-4d21-b0b1-46073e198aba

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/554/head:pr_554 && git checkout pr_554
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-7564fe6

@markmandel markmandel merged commit a2adb0a into googleforgames:master Feb 4, 2019
@markmandel markmandel added kind/bug These are bugs. area/operations Installation, updating, metrics etc labels Feb 4, 2019
@markmandel markmandel added this to the 0.8.0 milestone Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operations Installation, updating, metrics etc kind/bug These are bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants