Remove the custom kubectl commands from quickstarts #556

hpandeycodeit · 2019-02-04T19:28:31Z

Issue #521

Replace custom kubectl commands
kubectl get gs -o=custom-columns=NAME:.metadata.name,STATUS:.status.state,IP:.status.address,PORT:.status.ports

with kubectl get gs

markmandel · 2019-02-04T19:34:59Z

site/content/en/docs/Tutorials/allocator-service-go.md

 ```

 For a fleet of 2 replicas, you should see 2 Game Servers with a Status of Ready:
 ```
-NAME                     STATUS    IP               PORT
+NAME                     STATUS    IP               PORT                                    
 simple-udp-s2snf-765bc   Ready     35.231.204.26    [map[name:default port:7260]]


I'm 99% sure the output will change too - i.e. the port only has the first value displayed, rather than the map - so we should adjust those too 👍

But this is awesome!

@markmandel yes you are right. I have updated the output. Thanks for pointing it out :)

agones-bot · 2019-02-04T19:39:37Z

Build Succeeded 👏

Build Id: 26bfa174-87ed-4de6-a9ca-01434aade8ae

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-298e64a
image: gcr.io/agones-images/agones-sdk:0.8.0-298e64a
image: gcr.io/agones-images/agones-ping:0.8.0-298e64a
Linux C++ SDK (build: dev): agonessdk-0.8.0-298e64a-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-298e64a-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-298e64a-src.zip
SDK Server: agonessdk-server-0.8.0-298e64a.zip

A preview of the website will exist for the next 30 days:

https://298e64a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/556/head:pr_556 && git checkout pr_556
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-298e64a

agones-bot · 2019-02-04T19:42:52Z

Build Succeeded 👏

Build Id: 28d281fb-c652-4351-8655-5ffdaf44191a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-653d70e
image: gcr.io/agones-images/agones-sdk:0.8.0-653d70e
image: gcr.io/agones-images/agones-ping:0.8.0-653d70e
Linux C++ SDK (build: dev): agonessdk-0.8.0-653d70e-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-653d70e-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-653d70e-src.zip
SDK Server: agonessdk-server-0.8.0-653d70e.zip

A preview of the website will exist for the next 30 days:

https://653d70e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/556/head:pr_556 && git checkout pr_556
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-653d70e

agones-bot · 2019-02-04T20:04:08Z

Build Failed 😱

Build Id: d3641fa7-6159-465a-a5e5-5ce5a48b9180

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-02-04T20:46:38Z

Build Succeeded 👏

Build Id: 908b5b0f-7c67-4051-ae54-8ec3db74004b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-107091d
image: gcr.io/agones-images/agones-sdk:0.8.0-107091d
image: gcr.io/agones-images/agones-ping:0.8.0-107091d
Linux C++ SDK (build: dev): agonessdk-0.8.0-107091d-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-107091d-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-107091d-src.zip
SDK Server: agonessdk-server-0.8.0-107091d.zip

A preview of the website will exist for the next 30 days:

https://107091d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/556/head:pr_556 && git checkout pr_556
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-107091d

markmandel

I found some more outputs that need updating (inline)

Also some outputs on the webhook fleet autoscaler:
https://107091d-dot-preview-dot-agones-images.appspot.com/site/docs/getting-started/create-webhook-fleetautoscaler/

Thanks for doing all of these! 🍰

markmandel · 2019-02-04T22:14:12Z

site/content/en/docs/Getting Started/create-gameserver.md

@@ -134,7 +134,7 @@ You might also be interested to see the `Events` section, which outlines when va
 Let's retrieve the IP address and the allocated port of your Game Server :

 ```
-kubectl get gs -o=custom-columns=NAME:.metadata.name,STATUS:.status.state,IP:.status.address,PORT:.status.ports
+kubectl get gs


Lots of outputs on this page are the old output 😢
See: https://107091d-dot-preview-dot-agones-images.appspot.com/site/docs/getting-started/create-gameserver/

markmandel · 2019-02-04T22:15:22Z

site/content/en/docs/Getting Started/create-fleet.md

@@ -339,7 +339,7 @@ allocated a `GameServer` out of the fleet, and you can now connect your players
 A handy trick for checking to see how many `GameServers` you have `Allocated` vs `Ready`, run the following:

 ```
-kubectl get gs -o=custom-columns=NAME:.metadata.name,STATUS:.status.state,IP:.status.address,PORT:.status.ports
+kubectl get gs


outputs here are also still old for fleets:
https://107091d-dot-preview-dot-agones-images.appspot.com/site/docs/getting-started/create-fleet/

markmandel · 2019-02-04T22:15:56Z

site/content/en/docs/Getting Started/create-fleetautoscaler.md

@@ -150,7 +150,7 @@ Last Scale Time has been updated, and a scaling event has been logged.
 Double-check the actual number of game server instances and status by running

 ```
-kubectl get gs -o=custom-columns=NAME:.metadata.name,STATUS:.status.state,IP:.status.address,PORT:.status.ports
+kubectl get gs


Outputs on this page are still old too 😢
https://107091d-dot-preview-dot-agones-images.appspot.com/site/docs/getting-started/create-fleetautoscaler/

@markmandel I have changed in above files. Let me know if you still see any old output in there. Thanks!

agones-bot · 2019-02-05T09:41:26Z

Build Succeeded 👏

Build Id: a1fc1480-32d7-4cc9-8237-5f9ae1962b0b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-633b668
image: gcr.io/agones-images/agones-sdk:0.8.0-633b668
image: gcr.io/agones-images/agones-ping:0.8.0-633b668
Linux C++ SDK (build: dev): agonessdk-0.8.0-633b668-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-633b668-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-633b668-src.zip
SDK Server: agonessdk-server-0.8.0-633b668.zip

A preview of the website will exist for the next 30 days:

https://633b668-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/556/head:pr_556 && git checkout pr_556
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-633b668

markmandel · 2019-02-05T16:17:36Z

Found a few more:
https://633b668-dot-preview-dot-agones-images.appspot.com/site/docs/getting-started/create-gameserver/
Just under kubectl get gameservers

https://633b668-dot-preview-dot-agones-images.appspot.com/site/docs/getting-started/create-fleet/
Under kubectl get fleet and You can also see the GameServers that have been created by the Fleet by running kubectl get gameservers, the GameServer will be prefixed by simple-udp.

Also under the section Scale up the Fleet

Also This will get you a list of all the current GameSevers and their Status.State., has the wrong output (nodeName is not there usually)

https://633b668-dot-preview-dot-agones-images.appspot.com/site/docs/getting-started/create-webhook-fleetautoscaler/
This will get you a list of all the current GameSevers and their Status > State. - old format

Double-check the actual number of game server instances and status by running: - too much in the output.

You can run the test site with make site-server if you want to check manually before submitting the PR and looking for review.

hpandeycodeit · 2019-02-05T20:40:20Z

@markmandel corrected some more. I have checked by running make site-server as well.
However for webhook-fleetautoscaler was getting few errors on my minikube so there might still be some discrepency.

Maybe you can double check?

Thanks

agones-bot · 2019-02-05T20:48:40Z

Build Succeeded 👏

Build Id: 55e65c1c-089d-426a-938c-ab4a4bc85879

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-2604a63
image: gcr.io/agones-images/agones-sdk:0.8.0-2604a63
image: gcr.io/agones-images/agones-ping:0.8.0-2604a63
Linux C++ SDK (build: dev): agonessdk-0.8.0-2604a63-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-2604a63-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-2604a63-src.zip
SDK Server: agonessdk-server-0.8.0-2604a63.zip

A preview of the website will exist for the next 30 days:

https://2604a63-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/556/head:pr_556 && git checkout pr_556
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-2604a63

markmandel

I just realised I should use my own tools 😊

NAME               STATE     ADDRESS           PORT      NODE       AGE
simple-udp-g7hnv   Ready     192.168.122.220   7493      minikube   5m

I thought "NODE" was only -o wide - I was wrong. We can make this 'minikube' everywhere though.

Also found STATUS instead of state in places.

Sorry to keep bouncing this back to you 😞

markmandel · 2019-02-05T23:18:50Z

site/content/en/docs/Getting Started/create-fleet.md

@@ -339,18 +339,18 @@ allocated a `GameServer` out of the fleet, and you can now connect your players
 A handy trick for checking to see how many `GameServers` you have `Allocated` vs `Ready`, run the following:

 ```
-kubectl get gs -o=custom-columns=NAME:.metadata.name,STATUS:.status.state,IP:.status.address,PORT:.status.ports
+kubectl get gs
 ```

 This will get you a list of all the current `GameSevers` and their `Status > State`.

 ```
 NAME                     STATUS      IP               PORT


Suggested change

NAME STATUS IP PORT

NAME STATE IP PORT

markmandel · 2019-02-05T23:19:01Z

site/content/en/docs/Getting Started/create-fleet.md

@@ -424,15 +424,15 @@ kubectl create -f https://raw.githubusercontent.com/GoogleCloudPlatform/agones/{

 We should now have four `Ready` `GameServers` and one `Allocated`.

-We can check this by running `kubectl get gs -o=custom-columns=NAME:.metadata.name,STATUS:.status.state,IP:.status.address,PORT:.status.ports`.
+We can check this by running `kubectl get gs`.

 ```
 NAME                     STATUS      IP               PORT


Suggested change

NAME STATUS IP PORT

NAME STATE IP PORT

markmandel · 2019-02-05T23:19:10Z

site/content/en/docs/Getting Started/create-fleetautoscaler.md

@@ -150,16 +150,16 @@ Last Scale Time has been updated, and a scaling event has been logged.
 Double-check the actual number of game server instances and status by running

 ```
-kubectl get gs -o=custom-columns=NAME:.metadata.name,STATUS:.status.state,IP:.status.address,PORT:.status.ports
+kubectl get gs
 ``` 

 This will get you a list of all the current `GameSevers` and their `Status > State`.

 ```
 NAME                     STATUS      IP             PORT


Suggested change

NAME STATUS IP PORT

NAME STATE IP PORT

markmandel · 2019-02-05T23:19:18Z

site/content/en/docs/Getting Started/create-fleetautoscaler.md

@@ -223,15 +223,15 @@ might stay a bit in 'Unhealthy' state (and its pod in 'Terminating' until it get
 Double-check the actual number of game server instances and status by running

 ```
-kubectl get gs -o=custom-columns=NAME:.metadata.name,STATUS:.status.state,IP:.status.address,PORT:.status.ports
+kubectl get gs
 ``` 

 This will get you a list of all the current `GameSevers` and their `Status > State`.

 ```
 NAME                     STATUS    IP             PORT


Suggested change

NAME STATUS IP PORT

NAME STATE IP PORT

markmandel · 2019-02-05T23:19:27Z

site/content/en/docs/Getting Started/create-fleetautoscaler.md

@@ -241,17 +241,17 @@ applied live, without interruptions of service.

 Run `kubectl edit fleetautoscaler simple-udp-autoscaler` and set the `bufferSize` field to `5`. 

-Let's look at the list of game servers again. Run `watch kubectl get gs -o=custom-columns=NAME:.metadata.name,STATUS:.status.state,IP:.status.address,PORT:.status.ports`
+Let's look at the list of game servers again. Run `watch kubectl get gs`
 until you can see that are 5 ready server instances:

 ```
 NAME                     STATUS    IP             PORT


Suggested change

NAME STATUS IP PORT

NAME STATE IP PORT

markmandel · 2019-02-05T23:19:39Z

site/content/en/docs/Getting Started/create-gameserver.md

@@ -134,14 +134,14 @@ You might also be interested to see the `Events` section, which outlines when va
 Let's retrieve the IP address and the allocated port of your Game Server :

 ```
-kubectl get gs -o=custom-columns=NAME:.metadata.name,STATUS:.status.state,IP:.status.address,PORT:.status.ports
+kubectl get gs
 ```

 This should ouput your Game Server IP address and ports, eg:

 ```
 NAME         STATUS    IP               PORT


Suggested change

NAME STATUS IP PORT

NAME STATE IP PORT

markmandel · 2019-02-05T23:19:47Z

site/content/en/docs/Getting Started/create-webhook-fleetautoscaler.md

@@ -205,10 +205,10 @@ This will get you a list of all the current `GameSevers` and their `Status > Sta

 ```
 NAME                     STATUS      IP              PORT


Suggested change

NAME STATUS IP PORT

NAME STATE IP PORT

markmandel · 2019-02-05T23:19:53Z

site/content/en/docs/Tutorials/allocator-service-go.md

-NAME                     STATUS    IP               PORT
-simple-udp-s2snf-765bc   Ready     35.231.204.26    [map[name:default port:7260]]
-simple-udp-s2snf-vf6l8   Ready     35.196.162.169   [map[name:default port:7591]]
+NAME                     STATUS    IP               PORT                                    


Suggested change

NAME STATUS IP PORT

NAME STATE IP PORT

@markmandel hopefully this time it will be done :)

agones-bot · 2019-02-06T06:54:55Z

Build Succeeded 👏

Build Id: 4abdbf6f-7c6e-43b4-943a-cc19e5bb6dfd

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-f1780fe
image: gcr.io/agones-images/agones-sdk:0.8.0-f1780fe
image: gcr.io/agones-images/agones-ping:0.8.0-f1780fe
Linux C++ SDK (build: dev): agonessdk-0.8.0-f1780fe-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-f1780fe-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-f1780fe-src.zip
SDK Server: agonessdk-server-0.8.0-f1780fe.zip

A preview of the website will exist for the next 30 days:

https://f1780fe-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/556/head:pr_556 && git checkout pr_556
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-f1780fe

markmandel · 2019-02-06T16:18:55Z

More stuff
IP => ADDRESS

Also, can see where the IP/Address column doesn't line up with the content (needs an extra space in the column)

markmandel · 2019-02-09T18:15:49Z

Gentle bump on this - it's so close - would be awesome to have it for the 0.8.0 release! 👍

hpandeycodeit · 2019-02-10T03:30:08Z

@markmandel I missed the last notification. :(
Let me know if there is still anything pending, I will work on that too :)

agones-bot · 2019-02-10T03:39:34Z

Build Succeeded 👏

Build Id: 997d562c-9fd9-4183-9622-d510ac9b8be3

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-9793c85
image: gcr.io/agones-images/agones-sdk:0.8.0-9793c85
image: gcr.io/agones-images/agones-ping:0.8.0-9793c85
Linux C++ SDK (build: dev): agonessdk-0.8.0-9793c85-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-9793c85-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-9793c85-src.zip
SDK Server: agonessdk-server-0.8.0-9793c85.zip

A preview of the website (the last 30 builds are retained):

https://9793c85-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/556/head:pr_556 && git checkout pr_556
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-9793c85

markmandel · 2019-02-11T00:48:50Z

This looks perfect 👍 🎆

I just need you to rebase this down to a single commit, and I will approve it, and push it through! 👌
https://github.com/GoogleCloudPlatform/agones/blob/master/CONTRIBUTING.md#submitting-code-via-pull-requests

Updated the output Updated the output in multiple files corrected the outputs Added NODE and AGE in the output Minor changes to the output

hpandeycodeit · 2019-02-11T08:13:28Z

@markmandel done :)

agones-bot · 2019-02-11T08:19:25Z

Build Succeeded 👏

Build Id: a3edff60-7d1f-4647-8cb3-49c3f45d133a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-f7fa52f
image: gcr.io/agones-images/agones-sdk:0.8.0-f7fa52f
image: gcr.io/agones-images/agones-ping:0.8.0-f7fa52f
Linux C++ SDK (build: dev): agonessdk-0.8.0-f7fa52f-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-f7fa52f-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-f7fa52f-src.zip
SDK Server: agonessdk-server-0.8.0-f7fa52f.zip

A preview of the website (the last 30 builds are retained):

https://f7fa52f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/556/head:pr_556 && git checkout pr_556
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-f7fa52f

agones-bot · 2019-02-11T08:23:08Z

Build Succeeded 👏

Build Id: 1821a88b-a325-4ca8-ab75-badd24a1cead

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-fae7c07
image: gcr.io/agones-images/agones-sdk:0.8.0-fae7c07
image: gcr.io/agones-images/agones-ping:0.8.0-fae7c07
Linux C++ SDK (build: dev): agonessdk-0.8.0-fae7c07-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-fae7c07-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-fae7c07-src.zip
SDK Server: agonessdk-server-0.8.0-fae7c07.zip

A preview of the website (the last 30 builds are retained):

https://fae7c07-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/556/head:pr_556 && git checkout pr_556
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-fae7c07

markmandel

👌

hpandeycodeit force-pushed the docs_521 branch from 298e64a to 653d70e Compare February 4, 2019 19:31

markmandel reviewed Feb 4, 2019

View reviewed changes

markmandel added kind/documentation Documentation for Agones kind/cleanup Refactoring code, fixing up documentation, etc labels Feb 5, 2019

markmandel added this to the 0.8.0 milestone Feb 5, 2019

markmandel reviewed Feb 5, 2019

View reviewed changes

hpandeycodeit force-pushed the docs_521 branch from 9793c85 to f7fa52f Compare February 11, 2019 08:08

Remove the custom kubectl commands from quickstarts

fae7c07

Updated the output Updated the output in multiple files corrected the outputs Added NODE and AGE in the output Minor changes to the output

hpandeycodeit force-pushed the docs_521 branch from f7fa52f to fae7c07 Compare February 11, 2019 08:12

markmandel approved these changes Feb 11, 2019

View reviewed changes

markmandel merged commit 5fa7cba into googleforgames:master Feb 11, 2019

		@@ -205,10 +205,10 @@ This will get you a list of all the current `GameSevers` and their `Status > Sta

		```
		NAME STATUS IP PORT

Remove the custom kubectl commands from quickstarts #556

Remove the custom kubectl commands from quickstarts #556

Conversation

hpandeycodeit commented Feb 4, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Feb 4, 2019

agones-bot commented Feb 4, 2019

agones-bot commented Feb 4, 2019

agones-bot commented Feb 4, 2019

markmandel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Feb 5, 2019

markmandel commented Feb 5, 2019

hpandeycodeit commented Feb 5, 2019

agones-bot commented Feb 5, 2019

markmandel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Feb 6, 2019

markmandel commented Feb 6, 2019

markmandel commented Feb 9, 2019

hpandeycodeit commented Feb 10, 2019

agones-bot commented Feb 10, 2019

markmandel commented Feb 11, 2019

hpandeycodeit commented Feb 11, 2019

agones-bot commented Feb 11, 2019

agones-bot commented Feb 11, 2019

markmandel left a comment

Choose a reason for hiding this comment