Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prometheous installation on minikube #561

Merged
merged 2 commits into from
Feb 6, 2019
Merged

Fix prometheous installation on minikube #561

merged 2 commits into from
Feb 6, 2019

Conversation

markmandel
Copy link
Member

Just a small cleanup, and a typo.

@markmandel
Fix prometheous installation on minikube
94b21e1 
Just a small cleanup, and a typo.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Feb 6, 2019
@markmandel markmandel added this to the 0.8.0 milestone Feb 6, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d2d86233-5f15-4794-b90c-4f08b052cdf0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/561/head:pr_561 && git checkout pr_561
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-94b21e1

cyriltovena
cyriltovena approved these changes Feb 6, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0f63c3f8-f585-48ed-a069-19a3db0a6b89

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/561/head:pr_561 && git checkout pr_561
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-be824bf

@markmandel markmandel merged commit 7dfaa26 into googleforgames:master Feb 6, 2019
@markmandel markmandel deleted the cleanup/minikube-prom branch February 6, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @cyriltovena