Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simple-udp: added support for customizing labels and annotations by the caller #564

Merged
merged 1 commit into from
Feb 7, 2019
Merged

simple-udp: added support for customizing labels and annotations by the caller #564

merged 1 commit into from
Feb 7, 2019

Conversation

jkowalski
Copy link
Contributor

ANNOTATION
LABEL

are now supported in addition to no-parameters option

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9f5b4db3-2672-4d22-b1f6-17c57ea9255b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@jkowalski
Copy link
Contributor Author

should I split this one in two? first PR to make new release but don't use i yet, second to update all references 0.5=>0.6 ?

@markmandel
Copy link
Member

I'll grab the PR and push up the new image for you - just been busy with cleanup and stuff. It's on my todo list (and then I'll rebuild the PR once it's done)

markmandel
markmandel reviewed Feb 6, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably shouldn't edit the old blog post with a example release that didn't happen then 😄

site/content/en/blog/releases/0.7.0.md Outdated
@@ -44,7 +44,7 @@ Images available with this release:
- [gcr.io/agones-images/agones-controller:0.7.0](https://gcr.io/agones-images/agones-controller:0.7.0)
- [gcr.io/agones-images/agones-sdk:0.7.0](https://gcr.io/agones-images/agones-sdk:0.7.0)
- [gcr.io/agones-images/cpp-simple-server:0.4](https://gcr.io/agones-images/cpp-simple-server:0.4)
- [gcr.io/agones-images/udp-server:0.5](https://gcr.io/agones-images/udp-server:0.5)
- [gcr.io/agones-images/udp-server:0.6](https://gcr.io/agones-images/udp-server:0.6)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh, we should get rid of this - this is an old blog post

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed that.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1b73f09e-7369-4f75-9fe3-9a39e4065d8a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/564/head:pr_564 && git checkout pr_564
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-9780e3d

@markmandel markmandel added kind/feature New features for Agones area/examples Examples. Usually found in the `examples` directory labels Feb 7, 2019
@markmandel markmandel added this to the 0.8.0 milestone Feb 7, 2019
markmandel
markmandel approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkowalski
simple-udp: added support for customizing labels and annotations by t…
ffe6336 
…he caller

ANNOTATION key value
LABEL key value

are now supported in addition to no-parameter options.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 32df05be-a45f-44e9-b566-0752e85ed605

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/564/head:pr_564 && git checkout pr_564
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-ce657ee

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: efe02eaa-cce8-4171-9e62-bf96fb161f6b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/564/head:pr_564 && git checkout pr_564
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-ffe6336

@jkowalski jkowalski merged commit ba92be3 into googleforgames:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/examples Examples. Usually found in the `examples` directory kind/feature New features for Agones
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jkowalski @agones-bot @markmandel