Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of TestWorkQueueHealthCheck test #568

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Feb 7, 2019

Add check that workers actually started before we run main test logic.
If there are no workers live check returns true because 0 workers is
running. And then no error is generated cause workers has not started
(Healthy() return true even if no workers).

How to reproduce the fail seen on cloudbuild:
Add 1 second before Run():

    fun := func() {
        time.Sleep(1 * time.Second)
        wq.Run(1, stop)
    }
    go fun()

Add check that workers actually started before we run main test logic.
If there are no workers live check returns true because 0 workers is
running. And then no error is generated cause workers has not started
(Healthy() return true even if no workers).
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2b39be84-93dd-45f3-8b79-d44393bb230e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/568/head:pr_568 && git checkout pr_568
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-842b4bc

@jkowalski jkowalski merged commit 6f30bdb into googleforgames:master Feb 7, 2019
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Feb 7, 2019
@markmandel markmandel added this to the 0.8.0 milestone Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants