Add status subresource to fleet and Gameserverset #575

aLekSer · 2019-02-08T21:12:30Z

Switch to use UpdateStatus function for Fleets when it is necessary, add RBAC
permissions for "fleets/status" and "gameserversets/status".

agones-bot · 2019-02-08T21:22:28Z

Build Succeeded 👏

Build Id: 0ce04f01-27a4-4380-86c3-64c934a75fa4

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-2f3def3
image: gcr.io/agones-images/agones-sdk:0.8.0-2f3def3
image: gcr.io/agones-images/agones-ping:0.8.0-2f3def3
Linux C++ SDK (build: dev): agonessdk-0.8.0-2f3def3-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-2f3def3-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-2f3def3-src.zip
SDK Server: agonessdk-server-0.8.0-2f3def3.zip

A preview of the website (the last 30 builds are retained):

https://2f3def3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/575/head:pr_575 && git checkout pr_575
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-2f3def3

agones-bot · 2019-02-11T08:35:45Z

Build Succeeded 👏

Build Id: 2fdfe9e1-b192-4bb0-a569-85e3d2fb5e1b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-2920e68
image: gcr.io/agones-images/agones-sdk:0.8.0-2920e68
image: gcr.io/agones-images/agones-ping:0.8.0-2920e68
Linux C++ SDK (build: dev): agonessdk-0.8.0-2920e68-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-2920e68-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-2920e68-src.zip
SDK Server: agonessdk-server-0.8.0-2920e68.zip

A preview of the website (the last 30 builds are retained):

https://2920e68-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/575/head:pr_575 && git checkout pr_575
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-2920e68

markmandel · 2019-02-14T06:49:27Z

install/yaml/install.yaml

@@ -48,13 +48,13 @@ rules:
  resources: ["customresourcedefinitions"]
  verbs: ["get"]
 - apiGroups: ["stable.agones.dev"]
-  resources: ["gameservers", "gameserversets"]
+  resources: ["gameservers", "gameserversets", "gameserversets/status"]


Is there opportunity here to get more restrictive with our rbac permissions?

I mean - does the controller need to be able to update a gameserverset for example?

I will try to restrict them

@markmandel I have restricted new subresource permissions.
However cannot restrict gameserversets permissions. In fleets and fleetautoscalers controllers we are using main Resource endpoint gsSetCopy.Spec.Replicas and Spec.Replicas of the fleet:
https://github.com/GoogleCloudPlatform/agones/blob/0e92c90b9f0da86ab34cae53e74382113f56bf6e/pkg/fleets/controller.go#L268
https://github.com/GoogleCloudPlatform/agones/blob/0e92c90b9f0da86ab34cae53e74382113f56bf6e/pkg/fleetautoscalers/controller.go#L220

markmandel · 2019-02-14T06:49:39Z

install/yaml/install.yaml

  verbs: ["create", "delete", "get", "list", "update", "watch"]
 - apiGroups: ["stable.agones.dev"]
  resources: ["gameservers"]
  verbs: ["patch"]
 - apiGroups: ["stable.agones.dev"]
-  resources: ["fleets", "fleetallocations", "fleetautoscalers"]
+  resources: ["fleets", "fleets/status", "fleetallocations", "fleetautoscalers"]


Same as above - could we lock this down a little tighter?

agones-bot · 2019-02-14T07:29:10Z

Build Succeeded 👏

Build Id: a5b93280-06c3-475c-8cf1-ee457ac4f573

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-3a5fca4
image: gcr.io/agones-images/agones-sdk:0.8.0-3a5fca4
image: gcr.io/agones-images/agones-ping:0.8.0-3a5fca4
Linux C++ SDK (build: dev): agonessdk-0.8.0-3a5fca4-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-3a5fca4-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-3a5fca4-src.zip
SDK Server: agonessdk-server-0.8.0-3a5fca4.zip

A preview of the website (the last 30 builds are retained):

https://3a5fca4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/575/head:pr_575 && git checkout pr_575
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-3a5fca4

agones-bot · 2019-02-19T15:27:49Z

Build Succeeded 👏

Build Id: eb89262a-285b-46bc-82db-5c1f475592e3

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-bb319d9
image: gcr.io/agones-images/agones-sdk:0.8.0-bb319d9
image: gcr.io/agones-images/agones-ping:0.8.0-bb319d9
Linux C++ SDK (build: dev): agonessdk-0.8.0-bb319d9-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-bb319d9-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-bb319d9-src.zip
SDK Server: agonessdk-server-0.8.0-bb319d9.zip

A preview of the website (the last 30 builds are retained):

https://bb319d9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/575/head:pr_575 && git checkout pr_575
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-bb319d9

aLekSer · 2019-02-20T14:51:59Z

The small regression after applying this changes:
If the spec.Replicas in GSS was 0 initially then there are empty values on Status.Replicas , Ready and Allocated:

NAME                                                        SCHEDULING   DESIRED   CURRENT   ALLOCATED   READY     AGE                                                                                   
gameserverset.stable.agones.dev/scale-fleet-0-45ksj-5qrkp   Packed       30        30        0           30        25s 
gameserverset.stable.agones.dev/scale-fleet-1-szfqc-g5b8g   Packed       0                                         25s

markmandel · 2019-02-21T01:11:28Z

@aLekSer I'm guessing this is because there is no default values for those status items on creation? I'd be tempted to ask #sig-apimachinery to see why 0 values come as blank? (although not quite sure what the reason for this is -- feels like a k8s bug?)

I'm wondering if its something we need to worry about it? WDYT?

aLekSer · 2019-02-21T12:23:39Z

I think this is because status fields are not defined in yaml file and the only place Status are changed (inited) is here:
https://github.com/GoogleCloudPlatform/agones/blob/3a0e6d1c335413ee30dd8ebce555e18bd8620d75/pkg/gameserversets/controller.go#L557
I am looking for a fix, without it we would see empty printing columns if Spec.Replicas was always 0.

agones-bot · 2019-02-21T13:32:04Z

Build Failed 😱

Build Id: 897563be-bcc7-4b43-89d2-900e6f3a582d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-02-21T13:35:17Z

Build Failed 😱

Build Id: b38b858d-20ca-433d-93cb-6a293f93077b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-02-21T14:08:04Z

Build Failed 😱

Build Id: 5bfc7075-5e40-4ec1-8750-ecf685743aa9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2019-02-21T15:20:22Z

Some new error on a test step:
rm: cannot remove './public': No such file or directory
includes/website.mk:35: recipe for target 'site-static' failed
mkdir /workspace/site/public
make[2]: [site-static] Error 1 (ignored)

Main error was on controller_test.go TestControllerSyncFleet
Fixed in upcomming change.

agones-bot · 2019-02-21T16:00:36Z

Build Succeeded 👏

Build Id: 7c2c10f3-ab08-4c36-93af-61e1b5e7c5e4

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.9.0-b146278
image: gcr.io/agones-images/agones-sdk:0.9.0-b146278
image: gcr.io/agones-images/agones-ping:0.9.0-b146278
Linux C++ SDK (build: dev): agonessdk-0.9.0-b146278-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.9.0-b146278-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.9.0-b146278-src.zip
SDK Server: agonessdk-server-0.9.0-b146278.zip

A preview of the website (the last 30 builds are retained):

https://b146278-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/575/head:pr_575 && git checkout pr_575
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-b146278

markmandel · 2019-02-22T03:20:52Z

I am looking for a fix, without it we would see empty printing columns if Spec.Replicas was always 0.

Is the issue that the value is 0, or that status hasn't been set at all?

If you scale a fleet up to 5, and then back down to 0, does it go back to being blank?

I'm wondering if its because the status hasn't been created yet?

aLekSer · 2019-02-22T08:13:03Z

Hello @markmandel ,
I have fixed the issue. As you can see I added one more updateStatus on creating GameServerSet from fleet controller.

Is the issue that the value is 0, or that status hasn't been set at all?

Status were not set at all, but now it is set on creating GSS with aditional step (above).

If you scale a fleet up to 5, and then back down to 0, does it go back to being blank?

Now it always set right after create of GSS.

I'm wondering if its because the status hasn't been created yet?

Yes, that was the case, no all should be fine with yesterday fix.

aLekSer · 2019-02-22T08:14:38Z

pkg/fleets/controller.go

+		gsSetCopy.Status.ReadyReplicas = 0
+		gsSetCopy.Status.Replicas = 0
+		gsSetCopy.Status.AllocatedReplicas = 0
+		_, err = gsSets.UpdateStatus(gsSetCopy)


Here is an extra step which set default values.

Switch to using UpdateStatus function when it is necessary, add RBAC permissions for "fleets/status" and "gameserversets/status".

agones-bot · 2019-02-22T09:48:19Z

Build Succeeded 👏

Build Id: e406f1b9-7287-4201-b82a-9859e797dee8

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.9.0-efbac45
image: gcr.io/agones-images/agones-sdk:0.9.0-efbac45
image: gcr.io/agones-images/agones-ping:0.9.0-efbac45
Linux C++ SDK (build: dev): agonessdk-0.9.0-efbac45-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.9.0-efbac45-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.9.0-efbac45-src.zip
SDK Server: agonessdk-server-0.9.0-efbac45.zip

A preview of the website (the last 30 builds are retained):

https://efbac45-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/575/head:pr_575 && git checkout pr_575
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-efbac45

markmandel

🎲

agones-bot · 2019-02-23T09:07:27Z

Build Succeeded 👏

Build Id: 38af98c4-be7c-4e7a-8d02-795013154af4

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.9.0-eed2fbc
image: gcr.io/agones-images/agones-sdk:0.9.0-eed2fbc
image: gcr.io/agones-images/agones-ping:0.9.0-eed2fbc
Linux C++ SDK (build: dev): agonessdk-0.9.0-eed2fbc-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.9.0-eed2fbc-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.9.0-eed2fbc-src.zip
SDK Server: agonessdk-server-0.9.0-eed2fbc.zip

A preview of the website (the last 30 builds are retained):

https://eed2fbc-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/575/head:pr_575 && git checkout pr_575
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-eed2fbc

aLekSer force-pushed the fleet-status-subresource branch from 2f3def3 to 2920e68 Compare February 11, 2019 08:25

markmandel added kind/cleanup Refactoring code, fixing up documentation, etc feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Feb 12, 2019

markmandel reviewed Feb 14, 2019

View reviewed changes

aLekSer force-pushed the fleet-status-subresource branch from 2920e68 to 3a5fca4 Compare February 14, 2019 07:18

aLekSer force-pushed the fleet-status-subresource branch from 3a5fca4 to bb319d9 Compare February 19, 2019 15:18

markmandel removed feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Feb 21, 2019

aLekSer force-pushed the fleet-status-subresource branch 2 times, most recently from 1642362 to 9f953b1 Compare February 21, 2019 13:31

aLekSer force-pushed the fleet-status-subresource branch from 9f953b1 to b5f8118 Compare February 21, 2019 14:00

aLekSer force-pushed the fleet-status-subresource branch from b5f8118 to b146278 Compare February 21, 2019 15:50

aLekSer commented Feb 22, 2019

View reviewed changes

Add status subresource for Fleet and Gameserverset

efbac45

Switch to using UpdateStatus function when it is necessary, add RBAC permissions for "fleets/status" and "gameserversets/status".

aLekSer force-pushed the fleet-status-subresource branch from b146278 to efbac45 Compare February 22, 2019 09:39

markmandel approved these changes Feb 23, 2019

View reviewed changes

Merge branch 'master' into fleet-status-subresource

eed2fbc

markmandel merged commit 68d64e2 into googleforgames:master Feb 23, 2019

markmandel added this to the 0.9.0 milestone Feb 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add status subresource to fleet and Gameserverset #575

Add status subresource to fleet and Gameserverset #575

aLekSer commented Feb 8, 2019

agones-bot commented Feb 8, 2019

agones-bot commented Feb 11, 2019

markmandel Feb 14, 2019

aLekSer Feb 19, 2019

aLekSer Feb 19, 2019

markmandel Feb 14, 2019

agones-bot commented Feb 14, 2019

agones-bot commented Feb 19, 2019

aLekSer commented Feb 20, 2019

markmandel commented Feb 21, 2019

aLekSer commented Feb 21, 2019 •

edited

Loading

agones-bot commented Feb 21, 2019

agones-bot commented Feb 21, 2019

agones-bot commented Feb 21, 2019

aLekSer commented Feb 21, 2019 •

edited

Loading

agones-bot commented Feb 21, 2019

markmandel commented Feb 22, 2019

aLekSer commented Feb 22, 2019 •

edited

Loading

aLekSer Feb 22, 2019 •

edited

Loading

agones-bot commented Feb 22, 2019

markmandel left a comment

agones-bot commented Feb 23, 2019

Add status subresource to fleet and Gameserverset #575

Add status subresource to fleet and Gameserverset #575

Conversation

aLekSer commented Feb 8, 2019

agones-bot commented Feb 8, 2019

agones-bot commented Feb 11, 2019

markmandel Feb 14, 2019

Choose a reason for hiding this comment

aLekSer Feb 19, 2019

Choose a reason for hiding this comment

aLekSer Feb 19, 2019

Choose a reason for hiding this comment

markmandel Feb 14, 2019

Choose a reason for hiding this comment

agones-bot commented Feb 14, 2019

agones-bot commented Feb 19, 2019

aLekSer commented Feb 20, 2019

markmandel commented Feb 21, 2019

aLekSer commented Feb 21, 2019 • edited Loading

agones-bot commented Feb 21, 2019

agones-bot commented Feb 21, 2019

agones-bot commented Feb 21, 2019

aLekSer commented Feb 21, 2019 • edited Loading

agones-bot commented Feb 21, 2019

markmandel commented Feb 22, 2019

aLekSer commented Feb 22, 2019 • edited Loading

aLekSer Feb 22, 2019 • edited Loading

Choose a reason for hiding this comment

agones-bot commented Feb 22, 2019

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Feb 23, 2019

aLekSer commented Feb 21, 2019 •

edited

Loading

aLekSer commented Feb 21, 2019 •

edited

Loading

aLekSer commented Feb 22, 2019 •

edited

Loading

aLekSer Feb 22, 2019 •

edited

Loading