Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to htmltest link checker -- and fix issues #594

Merged
merged 2 commits into from
Feb 15, 2019

Conversation

markmandel
Copy link
Member

Made switch to htmltest because previous link checker didn't find lots of missing images, anchors that didn't exist, external URL checks, etc. These have all been fixed now.

This checker is brutally efficient at finding issues, although because it checks external URLs, it can not be the fastest. I've integrated the external URL cache into make site-test, which, when populated, runs the test in several seconds, which makes local testing nice.

Made switch to [htmltest](https://github.com/wjdp/htmltest) because previous
link checker didn't find lots of missing images, anchors that didn't exist,
external URL checks, etc. These have all been fixed now.

This checker is _brutally_ efficient at finding issues, although because it
checks external URLs, it can not be the fastest. I've integrated the
external URL cache into `make site-test`, which, when populated, runs the
test in several seconds, which makes local testing nice.
@markmandel markmandel added kind/bug These are bugs. area/site The website itself - including redirects, styling, search, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Feb 15, 2019
@markmandel markmandel added this to the 0.8.0 milestone Feb 15, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 876c0c79-a3dc-49de-8f0d-c29a1a2f1c24

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/594/head:pr_594 && git checkout pr_594
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-18e2066

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8a96f40d-9c95-49e6-99ee-90171be13bf5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/594/head:pr_594 && git checkout pr_594
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-30cd28c

@markmandel markmandel merged commit 7ef08a3 into googleforgames:master Feb 15, 2019
@markmandel markmandel deleted the site/fix-lifecycle branch February 20, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/site The website itself - including redirects, styling, search, etc area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants