Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organising Makefile into includes #615

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Organising Makefile into includes #615

merged 1 commit into from
Feb 22, 2019

Conversation

markmandel
Copy link
Member

Just moving some of the less "main" pieces into includes, so the build/Makefile isn't quite so unweildy.

Something I've wanted to do for a while.

@markmandel
Organising Makefile into includes
466bd17 
Just moving some of the less "main" pieces into includes,
so the build/Makefile isn't quite so unweildy.

Something I've wanted to do for a while.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Feb 21, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 94ce9b6d-28f1-4839-9e88-3dba9edc8fc1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/615/head:pr_615 && git checkout pr_615
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-466bd17

cyriltovena
cyriltovena approved these changes Feb 22, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@markmandel markmandel merged commit 047b23e into googleforgames:master Feb 22, 2019
@markmandel markmandel added this to the 0.9.0 milestone Feb 22, 2019
@markmandel markmandel deleted the cleanup/makefile branch February 22, 2019 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @cyriltovena